Source: herbstluftwm
Version: 0.8.0-2
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
herbstluftwm could not be built reproducibly.

This is because you did not pass "-u" / "--utc" to date(1), so it
varied depending on the build system's timezone even though the
underlying value was fixed.

Patch attached… which also uses SOURCE_DATE_EPOCH as you do not need
to call out to dpkg-parsechangelog.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
--- a/debian/rules      2020-04-11 19:34:20.623411284 +0100
--- b/debian/rules      2020-04-11 19:37:43.510924382 +0100
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-export BUILD_DATE = $(shell dpkg-parsechangelog -SDate | date -f- +"%Y-%m-%d")
+export BUILD_DATE = $(shell date -u -d@$(SOURCE_DATE_EPOCH) +"%Y-%m-%d")
 PYTEST_VERSION = $(shell python3 -c 'import sys ; print("py" + "".join([str(i) 
for i in sys.version_info[:2]]))')
 
 %:

Reply via email to