>>>>> John Paul Adrian Glaubitz
>>>>> on Tue, 24 Mar 2020 20:32:14 +0100 writes:
> Hi!
> On 3/24/20 8:01 PM, John Paul Adrian Glaubitz wrote:
>> It would be nice if this bug could be fixed as the missing r-base package
>> is blocking a lot of other packages on powerpc.
> This can be easily fixed by replacing __PPC64__ with __powerpc__ which is
defined
> on all PowerPC architectures (ppc64el, ppc64, powerpc).
Thanks a lot, Adrian!
{ When I had added __PPC64__ it was because it "seemed clear"
(by the OP, I don't have access to these architectures) that the
clause should only be used for powerpc architectures where
-mlong-double-128
is available / in used .. and so I would have "concluded"
would only apply to 64-bit pppc ..
}
But it seems using the macro instead of the static variable is
safer (albeit possibly somewhat slower when the code is run, but
that will probably also depend much on the compilation
optimizations ..).
I will change to use __powerpc__ now and wait some hours (on
a possible reply from you !) before committing the change to the
upstream sources.
Martin
> Suggestion to change the patch into:
> #if HAVE_LONG_DOUBLE && (SIZEOF_LONG_DOUBLE > SIZEOF_DOUBLE)
> +# ifdef __powerpc__
> + // PowerPC (when gcc has -mlong-double-128) breaks here ...
> +# define q_1_eps (1 / LDBL_EPSILON)
> +# else
> static LDOUBLE q_1_eps = 1 / LDBL_EPSILON;
> +# endif
> #else
> static double q_1_eps = 1 / DBL_EPSILON;
> #endif
> Proof that __powerpc__ is available on all three PowerPC targets.
> On powerpc architecture:
> (sid-powerpc-sbuild2)root@kapitsa:/# gcc -dM -E - < /dev/null|grep
__powerpc__
> #define __powerpc__ 1
> (sid-powerpc-sbuild2)root@kapitsa:/#
> On ppc64 architecture:
> (sid-ppc64-sbuild2)root@kapitsa:/# gcc -dM -E - < /dev/null|grep
__powerpc__
> #define __powerpc__ 1
> (sid-ppc64-sbuild2)root@kapitsa:/#
> On ppc64el architecture:
> (sid_ppc64el-dchroot)glaubitz@plummer:~$ gcc -dM -E - < /dev/null|grep
__powerpc__
> #define __powerpc__ 1
> (sid_ppc64el-dchroot)glaubitz@plummer:~$
> Thanks,
> Adrian
> --
> .''`. John Paul Adrian Glaubitz
> : :' : Debian Developer - glaub...@debian.org
> `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
> `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
