Package: munin
Version: 2.0.57-1
At the bottom of the /etc/init.d/munin script are two lines:
do_stop_cmd_override() true
do_start_cmd_override() true
This is **NOT** how you define a shell function. The function code needs to
be inside curly braces, and (because they're defined with a one-liner) the
functions need to end with a trailing semi-colon. Like so:
do_stop_cmd_override() { true ; }
do_start_cmd_override() { true ; }
Without this patch (attached), upgrading munin to 2.0.57-1 leaves the package
in a broken (installed/Failed-config, or "iF") state and results in the
following:
# systemctl status munin
● munin.service - LSB: Create munin master directories on boot
Loaded: loaded (/etc/init.d/munin; generated)
Active: failed (Result: exit-code) since Thu 2020-03-19 13:33:46 AEDT;
5min ago
Docs: man:systemd-sysv-generator(8)
Process: 3625739 ExecStart=/etc/init.d/munin start (code=exited, status=2)
Mar 19 13:33:46 ganesh systemd[1]: Starting LSB: Create munin master
directories on boot...
Mar 19 13:33:46 ganesh munin[3625739]: /etc/init.d/munin: line 30: syntax error
near unexpected token `true'
Mar 19 13:33:46 ganesh munin[3625739]: /etc/init.d/munin: line 30:
`do_stop_cmd_override() true'
Mar 19 13:33:46 ganesh systemd[1]: munin.service: Control process exited,
code=exited, status=2/INVALIDARGUMENT
Mar 19 13:33:46 ganesh systemd[1]: munin.service: Failed with result
'exit-code'.
Mar 19 13:33:46 ganesh systemd[1]: Failed to start LSB: Create munin master
directories on boot.
After patching and running 'dpkg --configure --pending':
● munin.service - LSB: Create munin master directories on boot
Loaded: loaded (/etc/init.d/munin; generated)
Active: active (exited) since Thu 2020-03-19 14:00:23 AEDT; 4min 45s ago
Docs: man:systemd-sysv-generator(8)
Process: 3699607 ExecStart=/etc/init.d/munin start (code=exited,
status=0/SUCCESS)
Mar 19 14:00:23 ganesh systemd[1]: Starting LSB: Create munin master
directories on boot...
Mar 19 14:00:23 ganesh munin[3699607]: Starting Preparing munin directories:
munin.
Mar 19 14:00:23 ganesh systemd[1]: Started LSB: Create munin master directories
on boot.
craig
--- munin.dpkg-dist 2020-03-14 03:40:22.000000000 +1100
+++ munin 2020-03-19 14:00:07.916057288 +1100
@@ -27,5 +27,5 @@
# there is no process to be started or stopped ("munin-update" is executed via cron)
-do_stop_cmd_override() true
-do_start_cmd_override() true
+do_stop_cmd_override() { true ; }
+do_start_cmd_override() { true ; }
