On 17/03/2020 01:21, Lorenzo Puliti wrote: > Package: src:dnsmasq > Followup-For: Bug #929884 > > > > -- System Information: > Debian Release: bullseye/sid > APT prefers unstable > APT policy: (500, 'unstable'), (1, 'experimental') > Architecture: amd64 (x86_64) > > Kernel: Linux 5.5.9-van (SMP w/4 CPU cores; PREEMPT) > Kernel taint flags: TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE > Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), > LANGUAGE=en_US:en (charmap=UTF-8) > Shell: /bin/sh linked to /bin/dash > Init: runit (via /run/runit.stopit) > >> [ I no longer using Debian, added new runit maintainer into CC. ] > > Hi, > >> Runscript is using #!/lib/runit/invoke-run as interpreter, which sources >> /etc/default/dnsmasq automatically. > > exactly > > About the patch, I suggest a change in the following part > >> +++ b/debian/dnsmasq.runit >> @@ -0,0 +1 @@ >> +debian/dnsmasq.runscript name=dnsmasq,logscript,since=2.80-1+runit >> diff --git a/debian/dnsmasq.runscript/finish >> b/debian/dnsmasq.runscript/finish >> new file mode 100755 >> index 0000000..cf35240 >> --- /dev/null >> > > If you use dh-runit >= 2.8.15 to build, the 'since' option is obsoleted (no > longer needed); > I've forgot to mention that in the manpage, I will add a note in the next > upload. > You probably want to add the 'presubj' option instead, that suggest the > reporter to add > the runit maintainer in CC when reporting a bug, if he is using runit > > the line would look like this > > +debian/dnsmasq.runscript name=dnsmasq,logscript,presubj > > In any case, if you decide to merge this and some runit-specific bug should > arise, feel > free to add me in CC, I will provide assistance. >
Thanks for the info. I merged the original patch with some changes and I've made the change you suggest as well. If you could check out the package as it stands in the dnsmasq git repo before the imminent 2.81 release, that would be great. http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=summary Cheers, Simon.
