Package: orthanc Version: 1.5.8+dfsg-3 Severity: wishlist Tags: patch User: team+bo...@tracker.debian.org Usertags: boost1.71
Dear Maintainer, your package fails to build with boost1.71. You can find a build log attached. If you want to attempt the build yourself, an updated version of boost-defaults which brings in boost1.71 dependencies can be found adding this line to your sources.list file: deb https://people.debian.org/~gio/reprepro gio main This bug has severity whishlist for the moment, but it will raised to RC as soon as version 1.71 of Boost is promoted to default. More specifically, your package fails building because of a little problem in the CMake script that probes Boost components. The attached patch should fix the bug. The same bug also happens in other orthanc-* packages, which appear to embed an orthanc source copy inside a tarball. Please, fix those as well because they are failing in the same way. If you want, I can file bugs. (as a side note: is the code embedding really necessary? In general I believe it should be avoided, but that's a different issue) Thanks and all the best, Giovanni. -- Giovanni Mascellani <g.mascell...@gmail.com> Postdoc researcher - Université Libre de Bruxelles
From 0a55a43c53500ac8cf466d2c6dd8e801679cb7e7 Mon Sep 17 00:00:00 2001
From: Giovanni Mascellani <g...@debian.org>
Date: Sat, 14 Mar 2020 14:43:34 +0100
Subject: [PATCH] Fix FTBFS with Boost 1.71.
---
debian/changelog | 7 ++++++
.../0001-Fix-FTBFS-with-Boost-1.71.patch | 24 +++++++++++++++++++
debian/patches/series | 1 +
3 files changed, 32 insertions(+)
create mode 100644 debian/patches/0001-Fix-FTBFS-with-Boost-1.71.patch
diff --git a/debian/changelog b/debian/changelog
index 5a425c8..abd335c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+orthanc (1.5.8+dfsg-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Patch CMake scripts to prevent FTBFS with Boost 1.71.
+
+ -- Giovanni Mascellani <g...@debian.org> Sat, 14 Mar 2020 14:42:52 +0100
+
orthanc (1.5.8+dfsg-3) unstable; urgency=medium
[ Alexandre Mestiashvili <mes...@debian.org> ]
diff --git a/debian/patches/0001-Fix-FTBFS-with-Boost-1.71.patch b/debian/patches/0001-Fix-FTBFS-with-Boost-1.71.patch
new file mode 100644
index 0000000..d154248
--- /dev/null
+++ b/debian/patches/0001-Fix-FTBFS-with-Boost-1.71.patch
@@ -0,0 +1,24 @@
+From: Giovanni Mascellani <g...@debian.org>
+Date: Sat, 14 Mar 2020 14:41:50 +0100
+Subject: Fix FTBFS with Boost 1.71.
+
+I am not a specialist of CMake, but I believe that quoting the
+component list makes scripts unable to interpret it as a list, similar
+to what would happen with bash.
+---
+ Resources/CMake/BoostConfiguration.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Resources/CMake/BoostConfiguration.cmake b/Resources/CMake/BoostConfiguration.cmake
+index 7666df6..376bef4 100644
+--- a/Resources/CMake/BoostConfiguration.cmake
++++ b/Resources/CMake/BoostConfiguration.cmake
+@@ -12,7 +12,7 @@ else()
+ endif()
+
+ list(APPEND ORTHANC_BOOST_COMPONENTS filesystem thread system date_time regex)
+- find_package(Boost COMPONENTS "${ORTHANC_BOOST_COMPONENTS}")
++ find_package(Boost COMPONENTS ${ORTHANC_BOOST_COMPONENTS})
+
+ if (NOT Boost_FOUND)
+ foreach (item ${ORTHANC_BOOST_COMPONENTS})
diff --git a/debian/patches/series b/debian/patches/series
index e69de29..8416969 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -0,0 +1 @@
+0001-Fix-FTBFS-with-Boost-1.71.patch
--
2.25.1
orthanc.log.gz
Description: application/gzip
signature.asc
Description: OpenPGP digital signature
