Package: hobbit-plugins
Version: 20191218
Severity: normal
Tags: patch

Dear Maintainer,

I have noticed that my PC is being flagged as having broken ntp settings after 
the update of ntp to 1:4.2.8p14+dfsg-1 in sid.
New ntp version seems to ship with updated ntpq output.
I checked which script generates this and fixed the regexp in 
/usr/lib/xymon/client/ext/ntpq
The xymon test on my PC no longer emits an erroneous alert.
I am attaching a patch, but it's a bit of a hatchet job. Please check if I 
didn't change something else unintentionally.

Kind regards,

-
Maciej Bonin <mbo...@phys.ethz.ch>            support: +41 44 633 26 68
IT Services Group, HPT H 8                    voice: +41 44 633 39 97
Department of Physics, ETH Zurich
CH-8093 Zurich, Switzerland                   http://nic.phys.ethz.ch/




-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-4-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8), LANGUAGE= 
(charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages hobbit-plugins depends on:
ii  dpkg          1.19.7
ii  xymon-client  4.3.30-1

Versions of packages hobbit-plugins recommends:
ii  binutils                2.34-4
ii  dctrl-tools             2.24-3+b1
ii  libfile-slurp-perl      9999.29-1
ii  libsort-naturally-perl  1.03-2
ii  libyaml-tiny-perl       1.73-1
ii  lsb-release             11.1.0
ii  lsof                    4.93.2+dfsg-1
ii  sudo                    1.8.31-1

Versions of packages hobbit-plugins suggests:
pn  bzr                           <none>
pn  cciss-vol-status              <none>
ii  debsums                       2.2.5
pn  ethtool                       <none>
pn  fping                         <none>
ii  git                           1:2.25.1-1
pn  hddtemp                       <none>
ii  ipmitool                      1.8.18-8
ii  iproute2                      5.5.0-1
pn  libdbd-pg-perl                <none>
ii  libfile-which-perl            1.23-1
ii  libipc-run-perl               20180523.0-2
ii  liblist-moreutils-perl        0.416-1+b5
ii  libnet-dns-perl               1.22-1
pn  libnet-tftp-perl              <none>
pn  libpoe-component-irc-perl     <none>
pn  libpoe-component-sslify-perl  <none>
ii  libtimedate-perl              2.3200-1
ii  libxml-twig-perl              1:3.50-2
pn  megaclisas-status             <none>
pn  mercurial                     <none>
ii  net-tools                     1.60+git20180626.aebd88e-1
ii  ntp                           1:4.2.8p14+dfsg-1
pn  nvidia-smi                    <none>
ii  smartmontools                 7.1-1
pn  subversion                    <none>

-- Configuration Files:
/etc/sudoers.d/xymon [Errno 13] Keine Berechtigung: '/etc/sudoers.d/xymon'
/etc/xymon/clientlaunch.d/mq.cfg changed [not included]
/etc/xymon/clientlaunch.d/sftbnc.cfg changed [not included]
/etc/xymon/clientlaunch.d/temp.cfg changed [not included]
/etc/xymon/misc.d/zombies changed [not included]

-- no debconf information
--- ntpq-broken 2020-03-10 15:05:27.396778432 +0100
+++ ntpq        2020-03-10 15:05:05.381095617 +0100
@@ -70,7 +70,7 @@
 foreach my $line (@output) {
        if ($line =~ /^  / or $line =~ /^==/) {
                $bb->print('   ' . $line);
-        } elsif ($line =~ /^\*\S+\s+\S+\s+\d+ 
\w\s+[\dm-]+\s+[\d-]+\s+[\d-]+\s+([\d\.-]+)\s+([\d\.-]+)\s+([\d\.-]+)/) {
+       } elsif ($line =~ /^\*\S+\s+\S+\s+\d+ 
\w\s+[\dm\-\+]+\s+[\d\-\+]+\s+[\d\-\+]+\s+([\d\.\-\+]+)\s+([\d\.\-\+]+)\s+([\d\.\-\+]+)/)
 {
                ($syspeer_stats->{'delay'}, $syspeer_stats->{'offset'}, 
$syspeer_stats->{'jitter'}) = ($1, $2, $3);
                $bb->color_line('green', $line);
                $found_syspeer = 1;

Reply via email to