Romain Porte wrote on Mon, Mar 09, 2020 at 10:33:29 +0100:
> Hello,
>
> 09/03/2020 02:51, Daniel Shahaf :
> > Thanks. Upstreaming would consist of emailing the patch to
> > zsh-work...@zsh.org and updating the metadata on this bug. However,
> > have you considered proposing the completion for inclusion in
> > devscripts, alongside dscverify(1) and its bash completion? devscripts
> > would just need to drop the completion file to
> > /usr/share/zsh/vendor-completions/
> > when installing.
>
> I have found that all the devscripts completion are coming from upstream
> directly, as you can check by inspecting the source package. I do not
> want to make an exception for dscverify completion to be shipped by
> devscripts while all other devscripts completions are coming from upstream.
>
> This has its pros and cons. I think pro is everyone based on dpkg gets
> the completions even without devscripts installed (maybe Ubuntu and
> such?) but con is that the completions can get outdated quickly as they
> live outside of the devscripts source package. We can see this by the
> currently open bugs on zsh-common about outdated devscripts completions.
>
> A debate can be made, but I think it is outside of the scope of this
> contribution. People from devscripts and upstream zsh should be involved
> in the discussion.
Well said, and I agree.
> All done, see attached v2 patch. You proposal for CURRENT == 2 worked
> fine, when I pass another option then the --no-conf suggestion
> disappears. Multiple keyring option seems possible, because according to
> strace each --keyring <file> is performing a fstat(file).
>
> Thanks for your feedback and have a nice day,
Thanks, v2 looks good. Would you please post it to zsh-work...@zsh.org?
I could just commit it upstream, but I'd like to have a second pair of eyes
over it.
> + '*:dsc file:_files -g "*.{changes,dsc}(-.)"'
In this line —
1. You may need to change «{foo,bar}» to «(foo|bar)» to avoid NO_MATCH errors
when foo exists but bar doesn't. (Once you do this, you may then need to
change «(-.)» to «(#q-.)».)
2. Add "buildinfo" alongside "changes" and "dsc".
Sorry for not catching these before.
Thanks,
Daniel
