Hi Mike, hi Emmanuel, Am 05.03.20 um 21:39 schrieb Mike Gabriel: > Hi Adrian, > > On Do 05 Mär 2020 15:05:04 CET, Adrian Vondendriesch wrote: > >> Hi Mike, >> >> Am 04.03.20 um 19:44 schrieb Mike Gabriel: >>> Hi Adrian, >>> >>> On Mo 02 Mär 2020 22:16:35 CET, Adrian Vondendriesch wrote: >>> >>>> Hi Mike, >>>> >>>> Am 02.03.20 um 08:42 schrieb Mike Gabriel: >>>>> Package: src:peewee >>>>> Severity: wishlist >>>>> X-Debbugs-Cc: adrian.vondendrie...@credativ.de >>>>> >>>>> Hi Adrian, >>>>> >>>>> for packaging GWE (GreenWithEnvy), a GPU (mostly NVidia) tweaking >>>>> tool, >>>>> I need an updated version of peewee in Debian unstable. >>>>> >>>>> Would you be available for updating the package the coming days? >>>> >>>> I've prepared a new upload. However, I need to have a close look at the >>>> build log. The testsuite prints some warnings and I would like to >>>> verify >>>> it doesn't include serious errors. >>> >>> Ok. Please ping me once you are ready for upload / have uploaded. >> >> Ping. > > Some feedback... > > * seconding Emmanuel Arias' request: don't put unstable in the first > d/changelog line, if you haven't uploaded, yet. > Use UNRELEASED instead.
Got it. Thanks. > * I personally don't like debcommit style commits, because they are > not cherry-pickable. > I normally do commit the changes only, but leave d/changelog untouched > (except for upstream version bumps). Then the last commit before > uploading is a commit that updates d/changelog from Git history > (using "gbp dch --auto") > > * Bump Standards-Version... Please document what changes were needed > to bump S-V: ... or explicitly say: "No changes needed." > >>>>> Otherwise, would you be ok with me doing a team upload? >>>> >>>> I'm always ok with team uploads ;) >>> >>> As you are currently my applicant in NM, I'd love to sponsor that upload >>> and also give feedback (if there is anything to be said after >>> reviewing). >> >> I've prepared the new upstream release. Feel free to have a look at it >> [1]. >> >> I appreciate your feedback. > > Given... > > Please fix stuff (Standards-Version -> no changes needed) in the > packaging, don't revert anything in Git. You're right the git commit message doesn't say "no changes needed". However, the changelog entry does. IMHO this should be enough for the moment. > Do you need me to sponsor the upload? I don't think so. Thanks. Regards, - Adrian
signature.asc
Description: OpenPGP digital signature
