Package: src:graphicsmagick Version: 1.4+really1.3.34+hg16230-1 Severity: minor Tags: patch
Hello. Short version: #935099 is not limited to PS/PDF, all image types are affected. Long version: The default priority (5) is used by dedicated viewers. Graphicsmagick can edit images, but should certainly not be the default viewer. The priority field exists exactly for this purpose according to the update-mime(8) manual page. A patch is attached. Thanks.
>From d40e57f05b8126ac98d16605b27b35ac6b40b481 Mon Sep 17 00:00:00 2001 From: Nicolas Boulenguez <nico...@debian.org> Date: Fri, 21 Feb 2020 09:45:36 +0100 Subject: [PATCH 1/2] mime: improve formatting --- debian/graphicsmagick.mime | 62 +++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/debian/graphicsmagick.mime b/debian/graphicsmagick.mime index a39f738..423350f 100644 --- a/debian/graphicsmagick.mime +++ b/debian/graphicsmagick.mime @@ -1,34 +1,34 @@ -image/avs; gm display 'avs:%s'; test=test -n "$DISPLAY" -image/bie; gm display 'bie:%s'; test=test -n "$DISPLAY" -image/x-ms-bmp; gm display 'bmp:%s'; test=test -n "$DISPLAY" -image/dcx; gm display 'dcx:%s'; test=test -n "$DISPLAY" -image/eps; gm display 'eps:%s'; test=test -n "$DISPLAY"; priority=2 -image/fax; gm display 'fax:%s'; test=test -n "$DISPLAY" -image/fits; gm display 'fits:%s'; test=test -n "$DISPLAY" -image/gif; gm display 'gif:%s'; test=test -n "$DISPLAY" -image/hdf; gm display 'hdf:%s'; test=test -n "$DISPLAY" -image/jpeg; gm display 'jpeg:%s'; test=test -n "$DISPLAY" -image/miff; gm display 'miff:%s'; test=test -n "$DISPLAY" -image/mtv; gm display 'mtv:%s'; test=test -n "$DISPLAY" +image/avs; gm display 'avs:%s'; test=test -n "$DISPLAY" +image/bie; gm display 'bie:%s'; test=test -n "$DISPLAY" +image/x-ms-bmp; gm display 'bmp:%s'; test=test -n "$DISPLAY" +image/dcx; gm display 'dcx:%s'; test=test -n "$DISPLAY" +image/eps; gm display 'eps:%s'; test=test -n "$DISPLAY";priority=2 +image/fax; gm display 'fax:%s'; test=test -n "$DISPLAY" +image/fits; gm display 'fits:%s';test=test -n "$DISPLAY" +image/gif; gm display 'gif:%s'; test=test -n "$DISPLAY" +image/hdf; gm display 'hdf:%s'; test=test -n "$DISPLAY" +image/jpeg; gm display 'jpeg:%s';test=test -n "$DISPLAY" +image/miff; gm display 'miff:%s';test=test -n "$DISPLAY" +image/mtv; gm display 'mtv:%s'; test=test -n "$DISPLAY" image/x-portable-bitmap; gm display 'pbm:%s'; test=test -n "$DISPLAY" -image/pcd; gm display 'pcd:%s'; test=test -n "$DISPLAY" -image/pcx; gm display 'pcx:%s'; test=test -n "$DISPLAY" -image/pdf; gm display 'pdf:%s'; test=test -n "$DISPLAY"; priority=2 -image/x-portable-graymap; gm display 'pgm:%s'; test=test -n "$DISPLAY" -image/pict; gm display 'pict:%s'; test=test -n "$DISPLAY" -image/png; gm display 'png:%s'; test=test -n "$DISPLAY" +image/pcd; gm display 'pcd:%s'; test=test -n "$DISPLAY" +image/pcx; gm display 'pcx:%s'; test=test -n "$DISPLAY" +image/pdf; gm display 'pdf:%s'; test=test -n "$DISPLAY";priority=2 +image/x-portable-graymap;gm display 'pgm:%s'; test=test -n "$DISPLAY" +image/pict; gm display 'pict:%s';test=test -n "$DISPLAY" +image/png; gm display 'png:%s'; test=test -n "$DISPLAY" image/x-portable-anymap; gm display 'pnm:%s'; test=test -n "$DISPLAY" image/x-portable-pixmap; gm display 'ppm:%s'; test=test -n "$DISPLAY" -image/ps; gm display 'ps:%s'; test=test -n "$DISPLAY"; priority=2 -image/rad; gm display 'rad:%s'; test=test -n "$DISPLAY" -image/rla; gm display 'rla:%s'; test=test -n "$DISPLAY" -image/rle; gm display 'rle:%s'; test=test -n "$DISPLAY" -image/sgi; gm display 'sgi:%s'; test=test -n "$DISPLAY" -image/sun-raster; gm display 'sun:%s'; test=test -n "$DISPLAY" -image/targa; gm display 'tga:%s'; test=test -n "$DISPLAY" -image/tiff; gm display 'tiff:%s'; test=test -n "$DISPLAY" -image/vid; gm display 'vid:%s'; test=test -n "$DISPLAY" -image/viff; gm display 'viff:%s'; test=test -n "$DISPLAY" -image/x-xbitmap; gm display 'xbm:%s'; test=test -n "$DISPLAY" -image/x-xpixmap; gm display 'xpm:%s'; test=test -n "$DISPLAY" -image/x-xwindowdump; gm display 'xwd:%s'; test=test -n "$DISPLAY" +image/ps; gm display 'ps:%s'; test=test -n "$DISPLAY";priority=2 +image/rad; gm display 'rad:%s'; test=test -n "$DISPLAY" +image/rla; gm display 'rla:%s'; test=test -n "$DISPLAY" +image/rle; gm display 'rle:%s'; test=test -n "$DISPLAY" +image/sgi; gm display 'sgi:%s'; test=test -n "$DISPLAY" +image/sun-raster; gm display 'sun:%s'; test=test -n "$DISPLAY" +image/targa; gm display 'tga:%s'; test=test -n "$DISPLAY" +image/tiff; gm display 'tiff:%s';test=test -n "$DISPLAY" +image/vid; gm display 'vid:%s'; test=test -n "$DISPLAY" +image/viff; gm display 'viff:%s';test=test -n "$DISPLAY" +image/x-xbitmap; gm display 'xbm:%s'; test=test -n "$DISPLAY" +image/x-xpixmap; gm display 'xpm:%s'; test=test -n "$DISPLAY" +image/x-xwindowdump; gm display 'xwd:%s'; test=test -n "$DISPLAY" -- 2.20.1
>From 87b78e46f2a9fc855e01d54d724f06ad58f5b9c2 Mon Sep 17 00:00:00 2001 From: Nicolas Boulenguez <nico...@debian.org> Date: Fri, 21 Feb 2020 09:46:22 +0100 Subject: [PATCH 2/2] mime: adjust priority for all images The default priority (5) is used by dedicated viewers. Graphicsmagick is intended for image edition ut should certainly not be the default viewer. he priority field exists exactly for this purpose according to the update-mime(8) manual page. This completes the changes introduced by #935099 for PS/PDF. --- debian/graphicsmagick.mime | 62 +++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/debian/graphicsmagick.mime b/debian/graphicsmagick.mime index 423350f..f486d66 100644 --- a/debian/graphicsmagick.mime +++ b/debian/graphicsmagick.mime @@ -1,34 +1,34 @@ -image/avs; gm display 'avs:%s'; test=test -n "$DISPLAY" -image/bie; gm display 'bie:%s'; test=test -n "$DISPLAY" -image/x-ms-bmp; gm display 'bmp:%s'; test=test -n "$DISPLAY" -image/dcx; gm display 'dcx:%s'; test=test -n "$DISPLAY" +image/avs; gm display 'avs:%s'; test=test -n "$DISPLAY";prority=2 +image/bie; gm display 'bie:%s'; test=test -n "$DISPLAY";prority=2 +image/x-ms-bmp; gm display 'bmp:%s'; test=test -n "$DISPLAY";prority=2 +image/dcx; gm display 'dcx:%s'; test=test -n "$DISPLAY";prority=2 image/eps; gm display 'eps:%s'; test=test -n "$DISPLAY";priority=2 -image/fax; gm display 'fax:%s'; test=test -n "$DISPLAY" -image/fits; gm display 'fits:%s';test=test -n "$DISPLAY" -image/gif; gm display 'gif:%s'; test=test -n "$DISPLAY" -image/hdf; gm display 'hdf:%s'; test=test -n "$DISPLAY" -image/jpeg; gm display 'jpeg:%s';test=test -n "$DISPLAY" -image/miff; gm display 'miff:%s';test=test -n "$DISPLAY" -image/mtv; gm display 'mtv:%s'; test=test -n "$DISPLAY" -image/x-portable-bitmap; gm display 'pbm:%s'; test=test -n "$DISPLAY" -image/pcd; gm display 'pcd:%s'; test=test -n "$DISPLAY" -image/pcx; gm display 'pcx:%s'; test=test -n "$DISPLAY" +image/fax; gm display 'fax:%s'; test=test -n "$DISPLAY";prority=2 +image/fits; gm display 'fits:%s';test=test -n "$DISPLAY";prority=2 +image/gif; gm display 'gif:%s'; test=test -n "$DISPLAY";prority=2 +image/hdf; gm display 'hdf:%s'; test=test -n "$DISPLAY";prority=2 +image/jpeg; gm display 'jpeg:%s';test=test -n "$DISPLAY";prority=2 +image/miff; gm display 'miff:%s';test=test -n "$DISPLAY";prority=2 +image/mtv; gm display 'mtv:%s'; test=test -n "$DISPLAY";prority=2 +image/x-portable-bitmap; gm display 'pbm:%s'; test=test -n "$DISPLAY";prority=2 +image/pcd; gm display 'pcd:%s'; test=test -n "$DISPLAY";prority=2 +image/pcx; gm display 'pcx:%s'; test=test -n "$DISPLAY";prority=2 image/pdf; gm display 'pdf:%s'; test=test -n "$DISPLAY";priority=2 -image/x-portable-graymap;gm display 'pgm:%s'; test=test -n "$DISPLAY" -image/pict; gm display 'pict:%s';test=test -n "$DISPLAY" -image/png; gm display 'png:%s'; test=test -n "$DISPLAY" -image/x-portable-anymap; gm display 'pnm:%s'; test=test -n "$DISPLAY" -image/x-portable-pixmap; gm display 'ppm:%s'; test=test -n "$DISPLAY" +image/x-portable-graymap;gm display 'pgm:%s'; test=test -n "$DISPLAY";prority=2 +image/pict; gm display 'pict:%s';test=test -n "$DISPLAY";prority=2 +image/png; gm display 'png:%s'; test=test -n "$DISPLAY";prority=2 +image/x-portable-anymap; gm display 'pnm:%s'; test=test -n "$DISPLAY";prority=2 +image/x-portable-pixmap; gm display 'ppm:%s'; test=test -n "$DISPLAY";prority=2 image/ps; gm display 'ps:%s'; test=test -n "$DISPLAY";priority=2 -image/rad; gm display 'rad:%s'; test=test -n "$DISPLAY" -image/rla; gm display 'rla:%s'; test=test -n "$DISPLAY" -image/rle; gm display 'rle:%s'; test=test -n "$DISPLAY" -image/sgi; gm display 'sgi:%s'; test=test -n "$DISPLAY" -image/sun-raster; gm display 'sun:%s'; test=test -n "$DISPLAY" -image/targa; gm display 'tga:%s'; test=test -n "$DISPLAY" -image/tiff; gm display 'tiff:%s';test=test -n "$DISPLAY" -image/vid; gm display 'vid:%s'; test=test -n "$DISPLAY" -image/viff; gm display 'viff:%s';test=test -n "$DISPLAY" -image/x-xbitmap; gm display 'xbm:%s'; test=test -n "$DISPLAY" -image/x-xpixmap; gm display 'xpm:%s'; test=test -n "$DISPLAY" -image/x-xwindowdump; gm display 'xwd:%s'; test=test -n "$DISPLAY" +image/rad; gm display 'rad:%s'; test=test -n "$DISPLAY";prority=2 +image/rla; gm display 'rla:%s'; test=test -n "$DISPLAY";prority=2 +image/rle; gm display 'rle:%s'; test=test -n "$DISPLAY";prority=2 +image/sgi; gm display 'sgi:%s'; test=test -n "$DISPLAY";prority=2 +image/sun-raster; gm display 'sun:%s'; test=test -n "$DISPLAY";prority=2 +image/targa; gm display 'tga:%s'; test=test -n "$DISPLAY";prority=2 +image/tiff; gm display 'tiff:%s';test=test -n "$DISPLAY";prority=2 +image/vid; gm display 'vid:%s'; test=test -n "$DISPLAY";prority=2 +image/viff; gm display 'viff:%s';test=test -n "$DISPLAY";prority=2 +image/x-xbitmap; gm display 'xbm:%s'; test=test -n "$DISPLAY";prority=2 +image/x-xpixmap; gm display 'xpm:%s'; test=test -n "$DISPLAY";prority=2 +image/x-xwindowdump; gm display 'xwd:%s'; test=test -n "$DISPLAY";prority=2 -- 2.20.1
