control: tag -1 +pending Hello dkg,
On Fri 31 Jan 2020 at 05:43PM -05, Daniel Kahn Gillmor wrote: > Thanks for the extensive review. I've revised imap-dl, taking it into > account, and have attached the revised version here. You can also find > it on my imap-dl-v2 branch on salsa. Very nice. Applied :) Thank you. > I've dug further into imaplib, and i've pushed the typeshed folks toward > annotating imaplib further based on those findings. We now expect the > response to the uids() call to be a list of items that alternates > between Tuple[bytes,bytes] and b')'. This is definitely more maintainable. >>> + fname = mdst.add(f[1].replace(b'\r\n', b'\n')) >> >> Could a message contain a mixture of UNIX and Windows line endings, such >> that this line corrupts the message? If not, please write a comment >> saying why it is always safe to perform this replacement. > > I know of no way to have this create an actual corruption, unless the > message itself doesn't actually have line endings at all (e.g. an 8-bit > attachment in a MIME message) but i don't have anything like that handy > and i've never seen it in practice. Okay, cool. >> Not a blocker, but it would be nice if the user could request that the >> expunge step be skipped. > > this is a pretty subtle distinction -- you want to set the Deleted flag > but not expunge? can you describe the use case? > >> Also, will imap-dl skip messages with the deleted flag? Do you think it >> should? > > I don't think it should -- the use case at the moment is just to fetch > all messages that exist in the inbox. Why should it treat any flag > differently? What I was thinking was that the user might want imap-dl to set the delete flag and not expunge, and then skip deleted messages on future runs. Then they'd expunge themselves from time-to-time. This way, if imap-dl makes any mistakes, there is a sort of backup. I was particularly thinking that someone might want to use this at first, until they could feel sure that imap-dl doesn't have any bugs with their particular IMAP server. -- Sean Whitton
signature.asc
Description: PGP signature
