Package: lttng-tools
Version: 2.11.1-1ubuntu1
Severity: normal
Dear Maintainer,
lttng-tools introduced a regression wrt session rotation when tracing
kernel domain - for more detailed info and a simple reproducer, see here:
https://bugs.launchpad.net/ubuntu/+source/ltt-control/+bug/1862936
See the attached debdiff for a fix (that i already applied & tested locally).
-- System Information:
Debian Release: bullseye/sid
APT prefers focal-proposed
APT policy: (500, 'focal-proposed'), (500, 'focal')
Architecture: amd64 (x86_64)
Kernel: Linux 5.4.0-14-generic (SMP w/8 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to
C.UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to C.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages lttng-tools depends on:
ii libc6 2.30-0ubuntu3
ii libkmod2 26-3ubuntu1
ii liblttng-ctl0 2.11.1-1
ii liblttng-ust-ctl4 2.11.0-1
ii libpopt0 1.16-14
ii liburcu6 0.11.1-2
ii libuuid1 2.34-0.1ubuntu6
ii libxml2 2.9.4+dfsg1-8ubuntu3
ii lsb-base 11.1.0ubuntu2
Versions of packages lttng-tools recommends:
ii babeltrace 1.5.8-1
Versions of packages lttng-tools suggests:
ii lttng-modules-dkms 2.10.8-1ubuntu2
-- no debconf information
diff -Nru ltt-control-2.11.1/debian/changelog
ltt-control-2.11.1/debian/changelog
--- ltt-control-2.11.1/debian/changelog 2020-02-06 21:50:54.000000000 +0000
+++ ltt-control-2.11.1/debian/changelog 2020-02-12 12:30:52.000000000 +0000
@@ -1,3 +1,9 @@
+ltt-control (2.11.1-1ubuntu1) focal; urgency=medium
+
+ * Fix session rotation within kernel domain tracing (LP: #1862936)
+
+ -- Paolo Pisati <paolo.pis...@canonical.com> Wed, 12 Feb 2020 12:30:52 +0000
+
ltt-control (2.11.1-1) unstable; urgency=medium
* [47b26b1] New upstream version 2.11.1
diff -Nru
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
---
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
1970-01-01 00:00:00.000000000 +0000
+++
ltt-control-2.11.1/debian/patches/0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
2020-02-12 12:29:59.000000000 +0000
@@ -0,0 +1,43 @@
+From 3029bc92f20d249ebea8779e46f6007aa0519b9a Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Galarneau?=
+ <jeremie.galarn...@efficios.com>
+Date: Thu, 19 Dec 2019 22:13:10 -0500
+Subject: [PATCH] Fix: sessiond: check for lttng-modules ABI 2.1 rather than
+ 2.8
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+The clear patchset introduces a regression that breaks session
+rotations when the kernel domain is used. The 2.8 lttng-modules ABI
+does not exist yet.
+
+The packet sequence number functionality was introduced in LTTng 2.8,
+which introduced the 2.1 kernel tracer ABI.
+
+Signed-off-by: Jérémie Galarneau <jeremie.galarn...@efficios.com>
+Change-Id: Ief97e7e25f6f0fcb5b5b97b39abb417c1eb327ec
+---
+ src/bin/lttng-sessiond/kernel.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/src/bin/lttng-sessiond/kernel.c b/src/bin/lttng-sessiond/kernel.c
+index 1f987ef7..2626e98b 100644
+--- a/src/bin/lttng-sessiond/kernel.c
++++ b/src/bin/lttng-sessiond/kernel.c
+@@ -1445,9 +1445,10 @@ int
kernel_supports_ring_buffer_packet_sequence_number(void)
+ }
+
+ /*
+- * Packet sequence number was introduced in 2.8
++ * Packet sequence number was introduced in LTTng 2.8,
++ * lttng-modules ABI 2.1.
+ */
+- if (abi.major >= 2 && abi.minor >= 8) {
++ if (abi.major >= 2 && abi.minor >= 1) {
+ /* Supported */
+ ret = 1;
+ } else {
+--
+2.25.0
+
diff -Nru ltt-control-2.11.1/debian/patches/series
ltt-control-2.11.1/debian/patches/series
--- ltt-control-2.11.1/debian/patches/series 2020-02-06 21:14:42.000000000
+0000
+++ ltt-control-2.11.1/debian/patches/series 2020-02-12 12:30:28.000000000
+0000
@@ -1,2 +1,3 @@
0001-Fix-compile-fails-for-x32-arch.patch
fix-lttng-health-check-manpage.patch
+0002-Fix-sessiond-check-for-lttng-modules-ABI-2.1-rather-.patch
