Hi Moritz, Moritz Mühlenhoff <j...@inutil.org> writes:
> On Tue, Dec 03, 2019 at 10:53:54PM +0100, Moritz Mühlenhoff wrote: >> >> I suggest that you go ahead with the salvaging, we're closing in on >> the Qt4 removal and we'll ask for removal of the remaining rdeps in >> about two months. > > Status update: Qt4 has now been droppped from testing, qt4 will be removed > from unstable by end of February (along with the remaining rdeps (currently > 15)). > > Nicholas, since you're a DM; if you need a sponsor for the initial upload > after adopting it, feel free to ping me. Yes, thank you, I would appreciate your review and sponsorship! This package is ready for an initial review. I have created a temporary repo here: https://salsa.debian.org/sten-guest/heimdall-flash and hope you will also be willing to create the project under debian namespace (the new collab-maint). Please don't create it before the package is ready for sponsorship though, because I haven't yet finalised the git repo format (see below for why). Here is the lint I believe may be a priority for this upload: W: heimdall-flash: appstream-metadata-missing-modalias-provide lib/udev/rules.d/60-heimdall-flash.rules W: heimdall-flash: appstream-metadata-missing-modalias-provide lib/udev/rules.d/60-heimdall-flash.rules match rule usb:v04E8p6601d* W: heimdall-flash: appstream-metadata-missing-modalias-provide lib/udev/rules.d/60-heimdall-flash.rules match rule usb:v04E8p685Dd* W: heimdall-flash: appstream-metadata-missing-modalias-provide lib/udev/rules.d/60-heimdall-flash.rules match rule usb:v04E8p68C3d* 1. I'm not sure what the correct approach is here, because we shouldn't suggest that a new user install a custom firmware to their device, just because they plugged it in. eg: a user who plugs in their phone or tablet to copy photos off of it shouldn't be presented (due to appstream) with software to replace their devices' OS! 2. I believe that many more devices are supported than this, and a list of USB manufacturer:product IDs feel like something that should be maintained upstream and not specifically in Debian. Moving forward, I suspect that a wiki page somewhere would be useful for collecting success/failure reports from users for a wider range of devices. W: heimdall-flash: manpage-has-bad-whatis-entry usr/share/man/man1/heimdall.1.gz I attempted to fix this with more comprehensive txt2man arguments, and concede that there are (arguably jarring) cosmetic issues with the resulting man page. I plan to work with upstream to provide the README in a format suitable for conversion to groff (eg: RST), so that one file can act as both README and man page source. OTTO upstream, I'm planning to also expand my CMake knowledge enough to fix the deficiencies in the existing CMakeLists.txt; Lisandro pointed me in the right direction for this :-) W: heimdall-flash source: source-contains-prebuilt-windows-binary Win32/Drivers/zadig.exe I haven't decided whether to go with a custom merge driver, gbp + d/copyright "Excluded-Files" + uscan, or something else. Please let me know what you'd prefer! I: heimdall-flash: hardening-no-bindnow usr/bin/heimdall I: heimdall-flash-frontend: hardening-no-bindnow usr/bin/heimdall-frontend In this case, I erred on the side of caution and left the "DEB_CFLAGS_MAINT_APPEND" added by Steve Langasek intact. I'd prefer to defer these changes to the next upload. Thank you for periodically asking me to check in, I appreciate the reminders and they motivate me to get the work done, and to do it well :-) Regards, Nicholas
signature.asc
Description: PGP signature
