On Mon, Feb 21, 2005 at 01:06:44PM -0800, Erich Schubert wrote:
> > so, would you not consider this bug closed if this trivial workaround
> > were provided?
> 
> No, I would consider it fixed if the wrapper is modified such that this
> works. The patch I sent was incomplete, but not too difficult to fix.

okay.  fair enough.

> You need to make two changes to the wrapper.
> First, upon recieving a signal you need to make a clean shutdown.
> My first patch assumed that $defaults is set, but it doesn't include
> "--defaults-extra-file=/etc/mysql/debian.cnf", thats one reason it
> didn't work.
> The second reason is that you need to use wait(), to be able to recieve
> signals on your own.

i'll take a closer look at the patch.

> Attached is a new diff; its untested (again...) because I'm short on

no it isn't :)

> it seems you can run mysql without the wrapper. Maybe Debian doesn't
> really need the wrapper either, but should just do the appropriate
> things in its init script?

you can run it without the wrapper, but i think the wrapper does a lot
of work that should be abstracted from the init script, which then
in turn keeps the init script much simpler (which is a good thing,
since the init script is a conffile).

so, i'll look more closely at the whole mysqld_safe situation, and if
we can do this in a not-so-invasive manner that doesn't break other
things, then great.  otherwise we can provide an alternative wrapper
specifically for systems that require being able to send mysql such
signals.  sound good?


        sean

-- 

Attachment: signature.asc
Description: Digital signature

Reply via email to