I have produced this patch (attached to this mail). If you think that this is not sufficient, tell me. The patch won't be merged until a couple of days anyway.
On Fri, Jan 10, 2020 at 04:18:40PM -0500, Simon Désaulniers wrote: > Hi again, > > Actually, I have just looked at the man page and the faulty behaviour is not > about the option `-n`, but the default program behaviour as you said > previously. > However, this is under documentation for `-n` that forking is mentioned. > Therefore, the second suggestion about removing the option just doesn't make > sense as a temporary fix for this issue. Consequently, a notice is best I > think. > > Regards, > > On Fri, Jan 10, 2020 at 04:07:22PM -0500, Simon Désaulniers wrote: > > Hi dirdi, > > > > You are right. Would you simply add a notice in the man page by forwarding > > to > > the upstream bug URL? Or would you totally remove the option from the man > > page? > > I am more tempted in doing the former. What do you think? > > > > Regards, > > > > On Mon, Jan 06, 2020 at 04:29:09AM +0100, dirdi wrote: > > > Package: i3lock-fancy > > > Version: 0.0~git20160228.0.0fcb933-2 > > > Followup-For: Bug #934444 > > > > > > I suggest to at least patch the man page and document the actual > > > behavior, since not forking might have severe security implications: E.g. > > > consider the following shell script which is supposed to lock the screen > > > and wipe all identities from the SSH agent: > > > > > > > #! /bin/sh > > > > i3lock-fancy > > > > ssh-add -d > > > > > > Instead of wiping those identities instantly they will not be wiped > > > before i3lock-fancy exits (i.e. screen being unlocked). > > > > -- > > Simon Désaulniers > > sim.desaulni...@gmail.com > > > > -- > Simon Désaulniers > sim.desaulni...@gmail.com -- Simon Désaulniers sim.desaulni...@gmail.com
diff --git a/debian/i3lock-fancy.1 b/debian/i3lock-fancy.1 index ba8b2c6..b0514c3 100644 --- a/debian/i3lock-fancy.1 +++ b/debian/i3lock-fancy.1 @@ -50,7 +50,11 @@ immediately. .TP \fB-n, --nofork\fP -Do not fork i3lock after starting. +Do not fork i3lock after starting. + +\fIIMPORTANT\fP: As of now, forking \fBdoes not\fP occur whether one uses `-n` or not. See +https://github.com/meskarune/i3lock-fancy/issues/144 for more information +regarding this bug. .TP \fB--\fP
signature.asc
Description: PGP signature
