Helmut Grohne: > On Sat, Jan 04, 2020 at 01:56:33AM +0000, Ximin Luo wrote: >> Please see also the attached patch to support cross-compiling which I needed >> in >> order to test that the first patch works. You can repeat the build yourself >> with an >> sbuild invocation like: > > Please refrain from applying the cross compilation patch as is. > Disabling features (such as ocaml bindings) is inappropriate for the > cross profile. The cross profile is only used for making cross > compilation work. It should not alter the generated package set nor > change package contents. For disabling ocaml bindings please use a > separate profile. Likely "noocaml" even though it isn't registered yet. > Registering it should be uncontroversial. In case java bindings need to > be disabled, there already is a "nojava" profile for that. >
To that end, one just needs to change "<!cross>" to "<!noocaml>" in my patch, as well as the line in d/rules where it tests "ifeq (,$(filter cross,$(DEB_BUILD_PROFILES)))" to test noocaml instead of cross. X -- GPG: ed25519/56034877E1F87C35 GPG: rsa4096/1318EFAC5FBBDBCE https://github.com/infinity0/pubkeys.git
