Control: tags -1 +moreinfo
On Thu, Dec 26, 2019 at 08:52:59PM +0100, Jörg Frings-Fürst wrote:
> Package name : ipmitool
> Version : 1.8.18-9
> Changes since the last upload:
>
> * debian/ipmitool.maintscript:
> - Fix syntax (Closes: #947384).
Were the p{re,ost}{inst,rm} scripts ever working? If they were, then your
new script above won't be enough: it looks for a single hash, while there
could be two: one with, and one without auto-disablement (ENABLED="false").
> * Remove System V init scripts:
> - Remove debian/ipmitool.ipmievd.init.
> - Remove debian/ipmitool.lintian-overrides.
> - Remove debian/ipmitool.postinst.
> - Rewrite debian/ipmitool.postrm.
> - Remove debian/ipmitool.prerm.
> - Remove override_dh_installinit from debian/rules.
> - Remove init-system-helpers (>> 1.50) from debian/control.
> - Add rm_conffile /etc/init.d/ipmievd 1.8.18-9~ ipmitool to
> debian/ipmitool.maintscript.
Er, what? You break the daemon on any rc system other than systemd, which
is a RC bug (a "must" requirement of Policy §9.11). And, it's a regression
-- both the existing package and upstream do ship init scripts.
If the module-loading code from in-archive version is no longer needed
(which your .service lacking that suggests), I'd simplify the obsolete stuff
away and use upstream init script as-is. Or, even better, replace it with
new-style:
#!/usr/bin/env /lib/init/init-d-script
### BEGIN INIT INFO
# Provides: ipmievd
# Required-Start: $remote_fs $syslog
# Required-Stop: $remote_fs $syslog
# Default-Start: 2 3 4 5
# Default-Stop: 0 1 6
# Short-Description: IPMI event daemon
# Description: ipmievd is a daemon which will listen for events
# from the BMC that are being sent to the SEL and
# also log those messages to syslog.
### END INIT INFO
DAEMON=/usr/sbin/ipmievd
DAEMON_ARGS="open daemon"
You could then drop the redundant .service for less code to maintain.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀ A MAP07 (Dead Simple) raspberry tincture recipe: 0.5l 95% alcohol,
⣾⠁⢠⠒⠀⣿⡁ 1kg raspberries, 0.4kg sugar; put into a big jar for 1 month.
⢿⡄⠘⠷⠚⠋⠀ Filter out and throw away the fruits (can dump them into a cake,
⠈⠳⣄⠀⠀⠀⠀ etc), let the drink age at least 3-6 months.
