Hi Eli, On Wed, 25 Dec 2019, Eli Schwartz wrote: > Could be. The patch doesn't clearly explain the rationale, so without
I send a message to debian-devel to reconfirm. Thanks for the details. > Fedora has a patch which completely prevents the application from > checking for application updates, but leaves the plugin updater check > running. Perhaps you would find this interesting? Really? The patch seems to remove the plugins update check code, too, at least to my eyes? But yeah, this is where I would patch code if necessary. > https://src.fedoraproject.org/rpms/calibre/blob/master/f/calibre-no-update.patch ... - try: - update_plugins = get_plugin_updates_available(raise_error=True) - if update_plugins is not None: - plugins_update_found = len(update_plugins) > Well, it cannot because it doesn't run as root... Ok, maybe I need to check how Debian builds packages on the build servers, I guess it is sbuild (while I use cowbuilder at home). Still, failing there doesn't sound right, but ... > I used to use XDG_DATA_DIRS in my recipe, until I eventually submitted > https://github.com/kovidgoyal/calibre/commit/2a63948440fe2d60a5573b829f27000d5c0389e2 > upstream to do this automatically when staging an install into a > packaging root. THanks, will look into my own patch again and see if it is still necessary, maybe it can still be dropped, but .. > xdg-desktop-menu does have some strange interactions with > /usr/share/gnome/apps, but AFAICT it manages to disable those bits if > the directory is not writable by the invoking user. Yes, that rings a bell with me, too, ... I will check whether the changes done by you above in upstream code make the changes of mine irrelevant. Thanks for the pointer. > Way back in the day, [...] let us forget these time. I wasn't working on Calibre, and I also don't feel responsible for what was done back then, but I will try to fix as much as possible, time, energy, and information allowing! > Taking a look at the current packaging you have, I'm happy to say that > nothing jumps out at me as problematic anymore. Thanks for your work > improving calibre on Debian. :) Thanks, hearing this from you (you have been a very consistent critique of the Debian packages on mobileread etc), I feel a bit relieved. And big thanks for all you valuable suggestions. Have some relaxed holidays (if you have), a good start into the new year, and I am looking forward to good collaboration in the next year! Best Norbert -- PREINING Norbert http://www.preining.info Accelia Inc. + IFMGA ProGuide + TU Wien + JAIST + TeX Live + Debian Dev GPG: 0x860CDC13 fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13
