Package: bsdgames Version: 2.17-28 Severity: normal Tags: patch Dear Maintainer,
In bsdgames 2.17.20, #579062[1] was supposedly fixed. However, `delay' is passed to usleep()[2]. Since the "fix" changed the default value of `delay' to 120, that makes the default delay 120 *micro*seconds instead of 120 *milli*seconds, making it practically the same as 0. Note that when "-d" is parsed, the integer argument is multiplied by 1000 before being used for the delay. The default delay should be 120000, not 120. See the following patch (apply with 'patch -p0 < fix-delay.patch'):
--- rain/rain.c~ 2018-10-13 20:05:55.000000000 -0400
+++ rain/rain.c 2019-12-22 23:41:11.723230711 -0500
@@ -70,7 +70,7 @@
{
int x, y, j;
long cols, lines;
- unsigned int delay = 120;
+ unsigned int delay = 120000;
unsigned long val = 0;
int ch;
char *ep;
Suggestion: Include this in
0005-rain-Update-default-delay.-Closes-579062.patch rather than creating
a new patch.
See also: #723808
Thanks,
Asher
Footnotes:
[1] Which suggests that the default delay should be changed to 120
milliseconds.
[2] Which has not been in POSIX since POSIX.1-2008 and has been
obsolete since POSIX.1-2001. But that is a different issue.
--
By necessity, by proclivity, and by delight, we all quote. In fact, it is as
difficult to appropriate the thoughts of others as it is to invent.
-- R. Emerson
-- Quoted from a fortune cookie program
(whose author claims, "Actually, stealing IS easier.")
[to which I reply, "You think it's easy for me to
misconstrue all these misquotations?!?" Ed.]
GPG fingerprint: 38F3 975C D173 4037 B397 8095 D4C9 C4FC 5460 8E68
-- System Information:
Debian Release: bullseye/sid
APT prefers testing-debug
APT policy: (500, 'testing-debug'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 5.3.0-3-amd64 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages bsdgames depends on:
ii libc6 2.29-3
ii libfl2 2.6.4-6.2
ii libgcc1 1:9.2.1-21
ii libncurses6 6.1+20191019-1
ii libstdc++6 9.2.1-21
ii libtinfo6 6.1+20191019-1
ii wamerican [wordlist] 2018.04.16-1
ii wamerican-insane [wordlist] 2018.04.16-1
ii wbritish [wordlist] 2018.04.16-1
bsdgames recommends no packages.
bsdgames suggests no packages.
-- no debconf information
signature.asc
Description: PGP signature
