Package: u-boot-menu
Version: 3
Severity: important
Tags: patch
Dear Maintainer,
With a /etc/fstab like this
#/dev/oldroot / ext4 defaults 0 1
/dev/newroot / ext4 defaults 0 1
u-boot-update will generate an extlinux.conf with 'root=#/dev/oldroot',
which will result in an un-bootable system.
The fix is quite simple, patch attached (the second '[' replaced with
'[[' just for consistency).
Kind regards,
Andrei
-- System Information:
Debian Release: 10.2
APT prefers proposed-updates
APT policy: (500, 'proposed-updates'), (500, 'stable'), (100, 'unstable')
Architecture: arm64 (aarch64)
Kernel: Linux 5.3.0-3-arm64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_UNSIGNED_MODULE
Locale: LANG=ro_RO.UTF-8, LC_CTYPE=ro_RO.UTF-8 (charmap=UTF-8),
LANGUAGE=ro_RO.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages u-boot-menu depends on:
ii linux-base 4.6
u-boot-menu recommends no packages.
Versions of packages u-boot-menu suggests:
pn flash-kernel <none>
-- Configuration Files:
/etc/default/u-boot changed [not included]
-- no debconf information
>From 99d3f8fc422d5e2a51356441939cb79c2bf41547 Mon Sep 17 00:00:00 2001
From: Andrei POPESCU <andreimpope...@gmail.com>
Date: Wed, 18 Dec 2019 13:20:08 +0200
Subject: [PATCH] Fix test to not match comments with no spaces in fstab
---
u-boot-update | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/u-boot-update b/u-boot-update
index 2bf151b..90dd58e 100755
--- a/u-boot-update
+++ b/u-boot-update
@@ -94,7 +94,7 @@ read _FS_SPEC _FS_FILE _FS_VFSTYPE _FS_MNTOPS _FS_FREQ
_FS_PASSNO << EOF
${_LINE}
EOF
- if [ "${_FS_SPEC}" != "#" ] && [ "${_FS_FILE}" = "/" ]
+ if [[ "${_FS_SPEC}" != "#"* ]] && [[ "${_FS_FILE}" == "/" ]]
then
U_BOOT_ROOT="root=${_FS_SPEC}"
break
--
2.20.1
