Hi Gregor, Thanks for the feedback, and the merges!
On Sun, Dec 08, 2019 at 09:08:57PM +0100, gregor herrmann wrote:
> Going throught the merge requests for perl packages, I noticed some
> issues around the handling of debian/upstream/metadata:
>
> - - The perl YAML libraries we use add "---\n" at the top of the file,
> which the used Python libraries in lintian-brush apparently don't
> do. No idea what is more correct or if it matters at all; I just
> noted that the removal of the line adds some noise.
I've noticed that as well. :-/ The Python YAML library that
lintian-brush is using claims to support roundtrip loading/dumping of
YAML files, but that has proven to be only partially true.
I've committed a fix to have lintian-brush at least preserve the
directives above each YAML document, which should reduce the size of
the diff.
> - - Sometimes when Contact and Name are removed, all that's left in our
> files is "Archive: CPAN" which is no so helpful. In those cases I
> just removed debian/upstream/metadata completely. Not sure if lintian-brush
> should do the same or if I should stop removing it or something
> else :)
> - - Similarly, if lintian-brush creates debian/upstream/metadata for a
> perl package, it might add "Archive: CPAN" (not that we use it but
> the Archive field exists …).
Agreed, it seems sensible to just remove the file in that case.
> - - The URLs lintian-brush finds in META.{json,yml} sometimes have room
> for improvement; in our tools [0] we e.g. fix github URLs to use
> https etc. It would be nice if lintian-brush could also learn some
> of these tricks.
This behaviour should be present in newer versions of lintian-brush
(>= 0.44). Some of the merge requests that you've seen may still have
non-canonical URLs if they were generated with older versions of
lintian-brush. I'll trigger a re-run for all perl packages with the
current version.
Cheers,
Jelmer
signature.asc
Description: PGP signature
