Package: librsvg
Version: 2.46.4-1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch
Dear maintainers,
In Ubuntu, we are in the process of moving the i386 architecture to a
compatibility-only layer on amd64, and therefore we are also moving our
autopkgtest infrastructure to test i386 binaries in a cross-environment.
This requires changes to some tests so that they are cross-aware and can do
the right thing.
The librsvg tests currently fail in this environment, because they are build
tests that do not invoke the toolchain in a cross-aware manner. I've
verified that the attached patch lets the tests successfully build (and run)
i386 tests on an amd64 host.
Note that upstream autopkgtest doesn't currently set DEB_HOST_ARCH so this
is a complete no-op in Debian for the moment. Support for cross-testing in
autopkgtest is currently awaiting review at
https://salsa.debian.org/ci-team/autopkgtest/merge_requests/69 and once
landed, will still have no effect unless autopkgtest is invoked with a '-a'
option. So this change should be safe to land in your package despite this
not being upstream in autopkgtest.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru librsvg-2.46.4/debian/tests/build librsvg-2.46.4/debian/tests/build
--- librsvg-2.46.4/debian/tests/build 2019-11-27 10:21:55.000000000 -0800
+++ librsvg-2.46.4/debian/tests/build 2019-12-08 20:36:43.000000000 -0800
@@ -8,6 +8,12 @@
cd "$AUTOPKGTEST_TMP"
+if [ -n "${DEB_HOST_GNU_TYPE:-}" ]; then
+ CROSS_COMPILE="$DEB_HOST_GNU_TYPE-"
+else
+ CROSS_COMPILE=
+fi
+
echo "1..1"
cat > simple.c <<'EOF'
@@ -26,7 +32,7 @@
}
EOF
-gcc -o simple simple.c $(pkg-config --cflags --libs librsvg-2.0 gobject-2.0)
+${CROSS_COMPILE}gcc -o simple simple.c $(${CROSS_COMPILE}pkg-config --cflags
--libs librsvg-2.0 gobject-2.0)
test -x simple
./simple
echo "# everything seems OK"
