Am Freitag, den 29.11.2019, 08:53 +0100 schrieb Johannes Schauer:
> On Wed, 13 Nov 2019 18:36:43 +0100 Benjamin Drung <
> benjamin.dr...@cloud.ionos.com> wrote:
> > > > When I developed the patch, I just checked that the tarball was
> > > > created
> > > > and the file size matches, but I didn't check the content.
> > > 
> > > ah indeed. This is of course because mmdebstrap assembles the
> > > tarball
> > > from two
> > > parts and then runs the compressor outside of tar. A correct
> > > patch
> > > probably
> > > look more like this:
> > > 
> > > @@ -161,7 +161,7 @@ sub get_tar_compressor($) {
> > >      } elsif ($filename =~ /\.lz4$/) {
> > >         return 'lz4';
> > >      } elsif ($filename =~ /\.(xz|txz)$/) {
> > > -       return 'xz';
> > > +       return ('xz', '--threads=0');
> > >      } elsif ($filename =~ /\.zst$/) {
> > >         return 'zstd';
> > >      }
> > 
> > I have tested this proposed change by dirty patching the two exec
> > lines:
> > 
> >     exec ($tar_compressor, '--threads=0') or error "[...]";
> > 
> > It works and creates a tarball. The generated tarball is actually
> > working
> > (verified by using it).
> 
> fixed in git:
> 
> https://gitlab.mister-muffin.de/josch/mmdebstrap/commit/9f2ea61265c36945b1fbbc27fd70099e58df794d

That commit does not work for me:

$ ./mmdebstrap -v buster buster.tar.xz
I: automatically chosen mode: unshare
I: chroot architecture amd64 is equal to the host's architecture
Can't exec "--threads=0": No such file or directory at ./mmdebstrap line 2303.
E: cannot exec --threads=0: No such file or directory
E: failed to start --threads=0

-- 
Benjamin Drung

Debian & Ubuntu Developer
Platform Engineering Compute (Enterprise Cloud)

1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Germany
E-mail: benjamin.dr...@cloud.ionos.com | Web: www.ionos.de

Hauptsitz Montabaur, Amtsgericht Montabaur, HRB 24498
Vorstand: Dr. Christian Böing, Hüseyin Dogan, Hans-Henning Kettler,
Matthias Steinberg, Achim Weiß
Aufsichtsratsvorsitzender: Markus Kadelke
Member of United Internet

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to