Package: fai-setup-storage
Version: 5.8.9
Severity: important

Dear Maintainer,

consider the following disk config:

disk_config disk1 disklabel:gpt bootable:1 fstabkey:uuid align-at:4k 
preserve_always:4

primary /boot/efi 512    vfat  rw
primary swap      1G     swap  sw
primary -         32G    -     -
primary /home     32G-   btrfs subvol=@home,defaults,rw,relatime,compress,nodev

disk_config btrfs fstabkey:uuid
btrfs single   /                disk1.3 
subvol=@buster,defaults,rw,relatime,compress
btrfs single   /var/cache       disk1.3 
subvol=@buster-var-cahce,defaults,rw,relatime,compress


When installing the releevant part of the log is this:

Calling task_partition
Starting setup-storage 2.2
Using config file: /var/lib/fai/config/disk_config/DISK_DESKTOP_GEN2T
/dev/nvme0n1p4 will be preserved
Adding mkfs command for '/dev/nvme0n1p3'.
Adding mkfs command for '/dev/nvme0n1p4'.
Executing: wipefs -af /dev/nvme0n1p1
Executing: wipefs -af /dev/nvme0n1p2
Executing: wipefs -af /dev/nvme0n1p3
Executing: parted -s /dev/nvme0n1 mklabel gpt
Executing: parted -s /dev/nvme0n1 mkpart primary "fat32" 1048576B 537919487B
Executing: parted -s /dev/nvme0n1 set 1 boot on
Executing: parted -s /dev/nvme0n1 mkpart primary "linux-swap" 537919488B 
1611661311B
Executing: parted -s /dev/nvme0n1 mkpart primary "" 1611661312B 35971399679B
Executing: parted -s /dev/nvme0n1 mkpart primary "btrfs" 35971399680B 
512110170111B
Executing: mkfs.vfat  /dev/nvme0n1p1
Executing: mkswap  /dev/nvme0n1p2
Executing: mkfs.btrfs -d single  -f /dev/nvme0n1p3
Executing: mount /dev/nvme0n1p3 /mnt
Executing: btrfs subvolume create   /mnt/@buster-var-cahce
Executing: umount /dev/nvme0n1p3
Executing: mkfs.btrfs -d single  -f /dev/nvme0n1p4
Executing: mount /dev/nvme0n1p4 /mnt
Executing: btrfs subvolume create   /mnt/@home
Executing: umount /dev/nvme0n1p4
Executing: mount /dev/nvme0n1p3 /mnt
Executing: btrfs subvolume create   /mnt/@buster
Executing: umount /dev/nvme0n1p3
Executing: parted /dev/nvme0n1 set 1 boot on
/dev/nvme0n1p3 UUID=b9e3ce83-aed9-4d3b-95eb-e86e2ab59d8a
/dev/nvme0n1p4 UUID=299d92a3-5d95-49e6-b18d-b73f2e4cc9ab
/dev/nvme0n1p3 UUID=b9e3ce83-aed9-4d3b-95eb-e86e2ab59d8a
/dev/nvme0n1p1 UUID=D380-1F2F
/dev/nvme0n1p2 UUID=ffcd663e-26a5-456c-86a0-61ce08a98f0a


As you can see wipefs honors the preserve_always, however the subsequent
mkfs calls do not, and the partition is recreated.

This appears to be a bug.

Cheers Jens



-- System Information:
Debian Release: 10.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fai-setup-storage depends on:
ii  e2fsprogs                 1.44.5-1+deb10u2
pn  liblinux-lvm-perl         <none>
pn  libparse-recdescent-perl  <none>
ii  parted                    3.2-25
ii  perl                      5.28.1-6

Versions of packages fai-setup-storage recommends:
ii  lvm2   2.03.02-3
pn  mdadm  <none>

Versions of packages fai-setup-storage suggests:
pn  cryptsetup     <none>
ii  dmsetup        2:1.02.155-3
pn  dosfstools     <none>
pn  jfsutils       <none>
pn  ntfs-3g        <none>
pn  reiserfsprogs  <none>
pn  xfsprogs       <none>

Reply via email to