Control: reopen 944145
Control: found 944145 2.36.0
The logic introduced in 1a9e33024cbffa15329b61ad281e9b8db8c46cf1 to fix
this bug is backwards. It is now suppressing the missing-install-key for
all standalone services, when it should be suppressing it for not
standalone services.
The following patch fixes the original bug and the new bug.
diff --git a/checks/systemd.pm b/checks/systemd.pm
index 263456c6d..f125a2d63 100644
--- a/checks/systemd.pm
+++ b/checks/systemd.pm
@@ -304,7 +304,7 @@ sub check_systemd_service_file {
$self->extract_service_file_values($file, 'Install', 'RequiredBy',1)
or $self->extract_service_file_values($file, 'Install', 'Also',1)
or $is_oneshot
- or $is_standalone
+ or not $is_standalone
or $file !~ m,^lib/systemd/[^\/]+/[^\/]+\.service$,
or $file =~ m,@\.service$,;
--
Richard
