Control: severity #838994 serious
Control: tag #838994 - wontfix

Hi all,

On 6/6/19 3:32 PM, Mike Gabriel wrote:
Hi folks,

On Tue, 28 May 2019 17:59:56 +0200 Andreas Beckmann <a...@debian.org> wrote:
> Followup-For: Bug #891493
> Control: severity -1 serious
>
> Hi,
>
> this unwarranted co-installability prevention between numix-gtk-theme and > murrine-themes also causes a stretch -> buster upgrade issue detected by > piuparts: numix-gtk-theme is kept at the version from stretch instead of
> being upgraded to buster:
>
> ...
> Starting 2 pkgProblemResolver with broken count: 1
> Investigating (0) numix-gtk-theme:amd64 < 2.6.6-1 -> 2.6.7-4 @ii umU Ib > > Broken numix-gtk-theme:amd64 Breaks on murrine-themes:amd64 < 0.98.11 @ii mK > (<= 0.98.11) > Considering murrine-themes:amd64 6 as a solution to numix-gtk-theme:amd64 0 > Holding Back numix-gtk-theme:amd64 rather than change murrine-themes:amd64
> Try to Re-Instate (1) numix-gtk-theme:amd64
> Done
> ...
> The following packages have been kept back:
> numix-gtk-theme
> ...
>
> And the solution for the actual problem that you want to get fixed is
> quite simple: use a virtual package, e.g. any-gtk-theme, any-gtk2-theme,
> any-murrine-theme or whatever fits the purpose best.
>
> Package: gtk2-engines-murrine
> Recommends: murrine-themes (>= 0.98) | any-gtk-theme
>
> Package: numix-gtk-theme
> Depends: gtk2-engines-murrine (>= 0.98)
> Provides: any-gtk-theme
> Breaks: n/a
>
> Installing numix-gtk-theme will pull in gtk2-engines-murrine, but the
> Recommends in gtk2-engines-murrine is already satisfied, so it won't
> pull in murrine-themes as well.
>
> See e.g. the opencl-icd virtual package serving a similar purpose.
>
>
> Andreas

as the Debian and upstream maintainer of arctica-greeter (which has numix theming a its default theme), I have an interest in getting the above issue resolved.

As I see it, we need an upload for murrine-themes here (which adds the "Recommends: murrine-themes (>= 0.98) | any-gtk-theme" line) and an upload of numix-gtk-theme (adding the corresponding Provides: any-gtk-theme).

@Corsac: could you do that for murrine-themes (or allow an NMU or team upload by me?).

@All: what would be the appropriate name for the virtual package here (any-gtk-theme? any-murrine-theme? ...?).

@JBicha: Let me know if you can handle that extra upload once agreed on a name for the virtual package, or if you can do the upload (I should be still under Uploaders: field, right?).

@All: would other theme packages be affected and should they then also Provide: the virtual package?

Please, let's get this solved before buster. Thanks.

Greets,
MIke

The above questions / suggestions I sent out on June 6th 2019. [1] Regarding the "Recommends: murrine-themes" situation in gtk2-engines-murrine, I'll have to add myself to the list of people having concerns about that.

Furthermore, I'd like to see some progress in this, so...

As I haven't had any reply nor statement nor veto nor anything from any of you on the above, here is what is going to happen, if noone interacts...

This basically follows Andreas Beckmann's suggestion of introducing a virtual package (any-murrine-theme):

Package: gtk2-engines-murrine

  * resurrect gtk2-engines-murrine on Salsa
  * prepare an NMU of gtk2-engines-murrine to DELAYED/7 (.debdiff attached)
    - recommending murrine-themes (>= ...) | any-murrine-theme
    - dropping shlibsdep on Gtk-2
    - some other minor packaging hygiene

Package: numix-gtk-theme

  * Prepare a team upload to DELAYED/7 (.debdiff attached)
    - Add a Provides: any-murrine-theme
    - some other minor packaging hygiene

Regarding #891493 and #838994, this should make as all happy:

  - If I install gtk2-engines-murrine, all the murrine-themes
    packages are pulled-in via Recommends: fields cascade.
  - If I install numix-gtk-theme, then only numix-gtk-theme
    (with gtk2-engines-murrine as hard dependency) gets pulled in.

All murrine themes now should also start providing "any-murrine-theme".

Regarding #883411 (Don't depend on libgtk2): This is not an Ubuntu-only effort anymore, it totally makes sense doing this in and for Debian, too.

light+love,
Mike


[1] https://bugs.debian.org/891493#22
diff -Nru gtk2-engines-murrine-0.98.2/debian/changelog 
gtk2-engines-murrine-0.98.2/debian/changelog
--- gtk2-engines-murrine-0.98.2/debian/changelog        2017-12-04 
20:54:03.000000000 +0100
+++ gtk2-engines-murrine-0.98.2/debian/changelog        2019-11-12 
10:22:20.000000000 +0100
@@ -1,3 +1,26 @@
+gtk2-engines-murrine (0.98.2-2.1) unstable; urgency=medium
+
+  [ Mike Gabriel ]
+  * Non-maintainer upload.
+  * debian/{control,compat}:
+    + Migrate to debhelper-compat notation. Bump DH compat level to version 12.
+  * debian/control:
+    + Add virtual package any-murrine-theme as alternative R for 
murrine-themes.
+      (Closes: #623783, #838994).
+    + Drop explicit D (gtk2-engines-murrine) on libgtk2.0-0. Thanks to Jeremy
+      Bicha for working on this. (Closes: #883411).
+    + Add Rules-Requires-Root: field and set it to "no".
+    + Bump Standards-Version: to 4.4.1. No changes needed.
+    + Update Vcs-*: fields. Packaging Git has been resurrected on
+      salsa.debian.org.
+  * debian/*: White-space cleanup.
+
+  [ Jeremy Bicha ]
+  * debian/rules:
+    + Exclude libgtk2.0-0 from dh_shlibdeps.
+
+ -- Mike Gabriel <sunwea...@debian.org>  Tue, 12 Nov 2019 10:22:20 +0100
+
 gtk2-engines-murrine (0.98.2-2) unstable; urgency=medium
 
   [ Jeremy Bicha ]
@@ -18,12 +41,12 @@
   * debian/watch updated to track xz tarballs.
   * debian/control:
     - update standards version to 4.0.0.
-  * Run wrap-and-sort. 
+  * Run wrap-and-sort.
   * debian/patches:
     - 01_fix-linking-pixman dropped, included upstream.
-    - 02_fix-linking-lm refreshed for new upstream. 
-    - 03_glib-single-include dropped, included upstream. 
-    - pango_cairo_update_layout refreshed for new upstream. 
+    - 02_fix-linking-lm refreshed for new upstream.
+    - 03_glib-single-include dropped, included upstream.
+    - pango_cairo_update_layout refreshed for new upstream.
 
  -- Yves-Alexis Perez <cor...@debian.org>  Mon, 24 Jul 2017 13:56:51 +0200
 
@@ -54,7 +77,7 @@
     - bump debhelper build dep to 9.
     - add dpkg-dev build-dep.
     - remove build-dep on hardening-includes.
-    - update standards version to 3.9.3. 
+    - update standards version to 3.9.3.
     - add a runtime dependency on a multiarch gtk2.             closes: #651223
   * debian/patches:
     - 3_glib-single-include added, include glib.h instead of individual header
@@ -124,7 +147,7 @@
   * debian/compat bumped to 7.
   * debian/rules:
     - LDFLAGS+=-Wl,-z,defs -Wl,--as-needed to LDFLAGS.
-    - switch to debhelper 7 with tiny rules. 
+    - switch to debhelper 7 with tiny rules.
 
  -- Yves-Alexis Perez <cor...@debian.org>  Wed, 18 Mar 2009 22:57:23 +0100
 
diff -Nru gtk2-engines-murrine-0.98.2/debian/compat 
gtk2-engines-murrine-0.98.2/debian/compat
--- gtk2-engines-murrine-0.98.2/debian/compat   2017-11-30 13:23:20.000000000 
+0100
+++ gtk2-engines-murrine-0.98.2/debian/compat   1970-01-01 01:00:00.000000000 
+0100
@@ -1 +0,0 @@
-10
diff -Nru gtk2-engines-murrine-0.98.2/debian/control 
gtk2-engines-murrine-0.98.2/debian/control
--- gtk2-engines-murrine-0.98.2/debian/control  2017-12-04 20:54:01.000000000 
+0100
+++ gtk2-engines-murrine-0.98.2/debian/control  2019-11-12 10:22:20.000000000 
+0100
@@ -2,17 +2,18 @@
 Section: x11
 Priority: optional
 Maintainer: Yves-Alexis Perez <cor...@debian.org>
-Build-Depends: debhelper (>= 10),
+Build-Depends: debhelper-compat (= 12),
                intltool,
                libgtk2.0-dev (>= 2.10.1)
-Standards-Version: 4.1.1
-Vcs-Browser: 
https://anonscm.debian.org/cgit/collab-maint/gtk2-engines-murrine.git
-Vcs-Git: https://anonscm.debian.org/git/collab-maint/gtk2-engines-murrine.git
+Standards-Version: 4.4.1
+Rules-Requires-Root: no
+Vcs-Browser: https://salsa.debian.org/debian/gtk2-engines-murrine/
+Vcs-Git: https://salsa.debian.org/debian/gtk2-engines-murrine.git
 
 Package: gtk2-engines-murrine
 Architecture: any
-Depends: libgtk2.0-0 (>= 2.24.5-4), ${misc:Depends}, ${shlibs:Depends}
-Recommends: murrine-themes (>= 0.98)
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Recommends: murrine-themes (>= 0.98) | any-murrine-theme,
 Multi-Arch: same
 Description: cairo-based gtk+-2.0 theme engine
  "Murrine" is an Italian word meaning the glass artworks done by Venicians
diff -Nru gtk2-engines-murrine-0.98.2/debian/rules 
gtk2-engines-murrine-0.98.2/debian/rules
--- gtk2-engines-murrine-0.98.2/debian/rules    2017-11-30 22:01:45.000000000 
+0100
+++ gtk2-engines-murrine-0.98.2/debian/rules    2019-11-12 10:22:20.000000000 
+0100
@@ -9,7 +9,10 @@
 
 override_dh_install:
        dh_install
-       rm -f 
debian/gtk2-engines-murrine/usr/lib/$(DEB_HOST_MULTIARCH)/gtk-2.0/2.10.0/engines/libmurrine.la
 
+       rm -f 
debian/gtk2-engines-murrine/usr/lib/$(DEB_HOST_MULTIARCH)/gtk-2.0/2.10.0/engines/libmurrine.la
+
+override_dh_shlibdeps:
+       dh_shlibdeps -- -xlibgtk2.0-0
 
 %:
        dh $@
diff -Nru numix-gtk-theme-2.6.7/debian/changelog 
numix-gtk-theme-2.6.7/debian/changelog
--- numix-gtk-theme-2.6.7/debian/changelog      2018-12-23 14:41:18.000000000 
+0100
+++ numix-gtk-theme-2.6.7/debian/changelog      2019-11-12 11:38:31.000000000 
+0100
@@ -1,3 +1,17 @@
+numix-gtk-theme (2.6.7-5) unstable; urgency=medium
+
+  * debian/{control,compat}:
+    + Switch to debhelper-compat notation. Bump DH comat level to version 12.
+  * debian/control:
+    + Revert Jeremy Bicha's work-around ("Add Breaks: murrine-themes")
+      for to-be-finally resolved Debian bug #838994 (in gtk2-engines-murrine).
+      (Closes: #891493).
+    + Add P (numix-gtk-theme): any-murrine-theme (related
+      to: #891493, thanks to Andreas Beckmann for suggesting a way out of 
this).
+    + Bump Standards-Version: to 4.4.1. No changes needed.
+
+ -- Mike Gabriel <sunwea...@debian.org>  Tue, 12 Nov 2019 11:38:31 +0100
+
 numix-gtk-theme (2.6.7-4) unstable; urgency=medium
 
   * Use sed to set Adwaita as default icon theme on Ubuntu
diff -Nru numix-gtk-theme-2.6.7/debian/compat 
numix-gtk-theme-2.6.7/debian/compat
--- numix-gtk-theme-2.6.7/debian/compat 2018-12-23 14:41:18.000000000 +0100
+++ numix-gtk-theme-2.6.7/debian/compat 1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-11
diff -Nru numix-gtk-theme-2.6.7/debian/control 
numix-gtk-theme-2.6.7/debian/control
--- numix-gtk-theme-2.6.7/debian/control        2018-12-23 14:41:18.000000000 
+0100
+++ numix-gtk-theme-2.6.7/debian/control        2019-11-12 11:38:10.000000000 
+0100
@@ -5,12 +5,12 @@
 Uploaders: Jeremy Bicha <jbi...@debian.org>,
            Mike Gabriel <sunwea...@debian.org>,
            Debian+Ubuntu MATE Packaging Team <debian-m...@lists.debian.org>
-Build-Depends: debhelper (>= 11),
+Build-Depends: debhelper-compat (= 12),
                libgdk-pixbuf2.0-dev,
                libglib2.0-bin,
                libxml2-utils,
                ruby-sass
-Standards-Version: 4.3.0
+Standards-Version: 4.4.1
 Homepage: https://github.com/numixproject/numix-gtk-theme
 Vcs-Git: https://salsa.debian.org/desktop-themes-team/numix-gtk-theme.git
 Vcs-Browser: https://salsa.debian.org/desktop-themes-team/numix-gtk-theme
@@ -21,7 +21,7 @@
 Depends: gtk2-engines-murrine (>= 0.98),
          ${misc:Depends},
          ${icon-theme:Depends}
-Breaks: ${murrine:Breaks}
+Provides: any-murrine-theme,
 Description: modern flat theme from the Numix project
  Numix is a modern flat theme with a combination of light and dark
  elements for any GTK-based desktop environment, including GNOME Shell,

Reply via email to