Hello, On Mon, Oct 28, 2019 at 11:32:38PM -0700, Steve Langasek wrote:
> I'm reopening this bug because consul 1.4.4~dfsg1-2 still FTBFS in Ubuntu,
> and the original rationale applies. You wrote that:
> > However the following packages are not direct dependencies of Consul
> > therefore they donot belong to Build-Depends. It is wrong to add those:
> > golang-github-aws-aws-sdk-go-dev
> > golang-google-api-dev
> This is not true. They happen to *also* be pulled in indirectly by other
> build-dependencies in Debian, which is why consul is not failing to build in
> Debian. However, the references to both aws-sdk-go and google.api are in
> the consul source, in
> vendor/github.com/hashicorp/go-discover/provider/aws/aws_discover.go and
> vendor/github.com/hashicorp/go-discover/provider/gce/gce_discover.go
> respectively. So consul should build-depend on them directly since it uses
> them directly, since future versions of the other build-dependencies may not
> depend on them in Debian either.
In addition, after adding these build dependencies, I found the package
still ftbfs with the following error:
[...]
src/github.com/hashicorp/consul/vendor/k8s.io/apimachinery/pkg/runtime/serializer/json/json.go:25:2:
cannot find package "github.com/ghodss/yaml" in any of:
/<<PKGBUILDDIR>>/_build/src/github.com/hashicorp/consul/vendor/github.com/ghodss/yaml
(vendor tree)
/usr/lib/go-1.12/src/github.com/ghodss/yaml (from $GOROOT)
/<<PKGBUILDDIR>>/_build/src/github.com/ghodss/yaml (from $GOPATH)
src/github.com/hashicorp/consul/vendor/k8s.io/client-go/tools/clientcmd/overrides.go:23:2:
cannot find package "github.com/spf13/pflag" in any of:
/<<PKGBUILDDIR>>/_build/src/github.com/hashicorp/consul/vendor/github.com/spf13/pflag
(vendor tree)
/usr/lib/go-1.12/src/github.com/spf13/pflag (from $GOROOT)
/<<PKGBUILDDIR>>/_build/src/github.com/spf13/pflag (from $GOPATH)
[...]
Adding golang-github-ghodss-yaml-dev and golang-github-spf13-pflag-dev fixes
this next failure.
> On Sat, Oct 19, 2019 at 12:21:04PM +0000, Debian Bug Tracking System wrote:
> > This is an automatic notification regarding your Bug report
> > which was filed against the consul package:
> >
> > #910714: consul: Please add missing build-dependencies to consul
> >
> > It has been closed by Dmitry Smirnov <only...@debian.org>.
> >
> > Their explanation is attached below along with your original report.
> > If this explanation is unsatisfactory and you have not received a
> > better one in a separate message then please contact Dmitry Smirnov
> > <only...@debian.org> by
> > replying to this email.
> >
> >
> > --
> > 910714: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910714
> > Debian Bug Tracking System
> > Contact ow...@bugs.debian.org with problems
>
> > Date: Sat, 19 Oct 2019 12:19:38 +0000
> > From: Dmitry Smirnov <only...@debian.org>
> > To: 910714-cl...@bugs.debian.org
> > Subject: Bug#910714: fixed in consul 1.4.4~dfsg1-1
> >
> > Source: consul
> > Source-Version: 1.4.4~dfsg1-1
> >
> > We believe that the bug you reported is fixed in the latest version of
> > consul, which is due to be installed in the Debian FTP archive.
> >
> > A summary of the changes between this version and the previous one is
> > attached.
> >
> > Thank you for reporting the bug, which will now be closed. If you
> > have further comments please address them to 910...@bugs.debian.org,
> > and the maintainer will reopen the bug report if appropriate.
> >
> > Debian distribution maintenance software
> > pp.
> > Dmitry Smirnov <only...@debian.org> (supplier of updated consul package)
> >
> > (This message was generated automatically at their request; if you
> > believe that there is a problem with it please contact the archive
> > administrators by mailing ftpmas...@ftp-master.debian.org)
> >
> >
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA256
> >
> > Format: 1.8
> > Date: Sat, 19 Oct 2019 21:02:23 +1100
> > Source: consul
> > Architecture: source
> > Version: 1.4.4~dfsg1-1
> > Distribution: unstable
> > Urgency: medium
> > Maintainer: Debian Go Packaging Team
> > <pkg-go-maintain...@lists.alioth.debian.org>
> > Changed-By: Dmitry Smirnov <only...@debian.org>
> > Closes: 910714 912259
> > Changes:
> > consul (1.4.4~dfsg1-1) unstable; urgency=medium
> > .
> > * New upstream release (Closes: #912259).
> > * Added missing B-Deps (Closes: #910714).
> > Thanks, Steve Langasek.
> > * Standards-Version: 4.4.1.
> > * Added more config examples.
> > * Added README.source with note about staying in sync with Nomad.
> > * Re-enabled tests.
> > Checksums-Sha1:
> > 9fe18da8b38ff55eb1f1c1e5bd8f63e25a71ddb1 5405 consul_1.4.4~dfsg1-1.dsc
> > 51004d179f9fa809f091b518f1f48e6ca820c6cd 4985528
> > consul_1.4.4~dfsg1.orig.tar.xz
> > ed28d3eff3ab84bb402d1f4e1bf315e177821744 14416
> > consul_1.4.4~dfsg1-1.debian.tar.xz
> > ac0e5416e2939cf7ae0dbb9de88a1b5e7e1f8854 21179
> > consul_1.4.4~dfsg1-1_amd64.buildinfo
> > Checksums-Sha256:
> > 7259bae6ea37f0f05a353641eb20948f50aad6dea7bce9cb4f1f9295f6eb1aa5 5405
> > consul_1.4.4~dfsg1-1.dsc
> > 01d2d85012b34fd85048177a2959e0230ff893515fd7ca2b886bbc8b43dfeedf 4985528
> > consul_1.4.4~dfsg1.orig.tar.xz
> > 75771eb25fb820a7ba641e36cf07a7519dedb12c72b36ed02c8f98f9154ad2fe 14416
> > consul_1.4.4~dfsg1-1.debian.tar.xz
> > 6347bd34669743320d9cae4128203fb881759de07c55d6e892e1e50981a815ac 21179
> > consul_1.4.4~dfsg1-1_amd64.buildinfo
> > Files:
> > ca520f0e569df94076fa25c6da742451 5405 devel optional
> > consul_1.4.4~dfsg1-1.dsc
> > c6edfe78a0610ae1461fe720a914b125 4985528 devel optional
> > consul_1.4.4~dfsg1.orig.tar.xz
> > 3a8f4a594dacd58a18a9b02e4f418b77 14416 devel optional
> > consul_1.4.4~dfsg1-1.debian.tar.xz
> > 0b7b065d4d19cdf93225a7ddffefb82d 21179 devel optional
> > consul_1.4.4~dfsg1-1_amd64.buildinfo
> >
> > -----BEGIN PGP SIGNATURE-----
> >
> > iQIzBAEBCAAdFiEEULx8+TnSDCcqawZWUra72VOWjRsFAl2q+uwACgkQUra72VOW
> > jRu8jA//bgzHF4bkdqzZDhcBeubiPZ6huFjB47PVPN10Fg4CuHRdDzIHpFSyvHyc
> > ZWo1xk7lj5c3OsWLmkKJ+2rvTGLhvO0x4fnF8IQTP1EYjbXqQqgjZGA93zpnGMWc
> > z347v+zSNI998hFBNDyn1rBDnja7answcQAANQKc/rUOiPdQyjH8C4t+udpH3/SQ
> > TRRZIo5ecbEqxxU9eQBt1YtEJF3cv9VYKRSUntziiO5LZxf3yb2ukB9Pd0pO/huW
> > zl2+dZHNlK2HIHnfz9mfuNKTm9NChZkPcJ7OcxmXX5X5rmpneZpZuEJOxkJoa7hk
> > 8/TCjzpNLf5dMbI6CLmse4lv+1OkaQuq2d+two2VzOX4Xq271pzjVbpyQJyaLbW2
> > GDy8lh7YCvmh08+OSuYmR5PmYJHbBdPdVo21jZQnrCj4AJW7fNHXz9UXpfCBVh0h
> > ZG6feW2Bh2c3Mkhpq8vmy7JA4OqM1ufw/s7ElUqHEXiUpcvTG7tFDQetFH0FyHS0
> > thjCWDJaFelD+8cLFDmTmckCfaqULGs3QtkNjOv7T0SpVktxfU1ZmxyZGEPAoWVh
> > poQeSZhfHH1reM1d9Uk/Gt7kiL/pRMcCjTCWl+9S30fxGP8Q1iAtQ5/SX/bKG/lf
> > +B5P+rbnCuamOiPz2V60/gji0W4jwlD4yzavwJ3qrKtA0Fn+GEU=
> > =mjLg
> > -----END PGP SIGNATURE-----
>
> > Date: Tue, 09 Oct 2018 23:00:55 -0700
> > From: Steve Langasek <steve.langa...@canonical.com>
> > To: Debian Bug Tracking System <sub...@bugs.debian.org>
> > Subject: consul: Please add missing build-dependencies to consul
> > X-Mailer: reportbug 7.1.8ubuntu1
> >
> > Package: consul
> > Version: 1.0.7~dfsg1-5
> > Severity: normal
> > Tags: patch
> > User: ubuntu-de...@lists.ubuntu.com
> > Usertags: origin-ubuntu cosmic ubuntu-patch
> >
> > Dear maintainers,
> >
> > While the consul source package has successfully built in Debian, in Ubuntu
> > we find that it is failing to build because certain go libraries that are
> > needed by the source but are not declared as build-dependencies happen to
> > not be pulled in as indirect build-dependencies.
> >
> > cd _build && go install
> > -gcflags=\"-trimpath=/<<BUILDDIR>>/consul-1.0.7\~dfsg1/_build/src\"
> > -asmflags=\"-trimpath=/<<BUILDDIR>>/consul-1.0.7\~dfsg1/_build/src\" -v -p
> > 4 github.com/hashicorp/consul github.com/hashicorp/consul/acl
> > github.com/hashicorp/consul/agent github.com/hashicorp/consul/agent/ae
> > github.com/hashicorp/consul/agent/checks
> > github.com/hashicorp/consul/agent/config
> > github.com/hashicorp/consul/agent/consul
> > github.com/hashicorp/consul/agent/consul/autopilot
> > github.com/hashicorp/consul/agent/consul/fsm
> > github.com/hashicorp/consul/agent/consul/prepared_query
> > github.com/hashicorp/consul/agent/consul/state
> > github.com/hashicorp/consul/agent/exec
> > github.com/hashicorp/consul/agent/local
> > github.com/hashicorp/consul/agent/metadata
> > github.com/hashicorp/consul/agent/mock
> > github.com/hashicorp/consul/agent/pool
> > github.com/hashicorp/consul/agent/router
> > github.com/hashicorp/consul/agent/structs
> > github.com/hashicorp/consul/agent/systemd
> > github.com/hashicorp/consul/agent/token github.com/hashicorp/consul/api
> > github.com/hashicorp/consul/command
> > github.com/hashicorp/consul/command/agent
> > github.com/hashicorp/consul/command/catalog
> > github.com/hashicorp/consul/command/catalog/list/dc
> > github.com/hashicorp/consul/command/catalog/list/nodes
> > github.com/hashicorp/consul/command/catalog/list/services
> > github.com/hashicorp/consul/command/event
> > github.com/hashicorp/consul/command/exec
> > github.com/hashicorp/consul/command/flags
> > github.com/hashicorp/consul/command/forceleave
> > github.com/hashicorp/consul/command/info
> > github.com/hashicorp/consul/command/join
> > github.com/hashicorp/consul/command/keygen
> > github.com/hashicorp/consul/command/keyring
> > github.com/hashicorp/consul/command/kv
> > github.com/hashicorp/consul/command/kv/del
> > github.com/hashicorp/consul/command/kv/exp
> > github.com/hashicorp/consul/command/kv/get
> > github.com/hashicorp/consul/command/kv/imp
> > github.com/hashicorp/consul/command/kv/impexp
> > github.com/hashicorp/consul/command/kv/put
> > github.com/hashicorp/consul/command/leave
> > github.com/hashicorp/consul/command/lock
> > github.com/hashicorp/consul/command/maint
> > github.com/hashicorp/consul/command/members
> > github.com/hashicorp/consul/command/monitor
> > github.com/hashicorp/consul/command/operator
> > github.com/hashicorp/consul/command/operator/autopilot
> > github.com/hashicorp/consul/command/operator/autopilot/get
> > github.com/hashicorp/consul/command/operator/autopilot/set
> > github.com/hashicorp/consul/command/operator/raft
> > github.com/hashicorp/consul/command/operator/raft/listpeers
> > github.com/hashicorp/consul/command/operator/raft/removepeer
> > github.com/hashicorp/consul/command/reload
> > github.com/hashicorp/consul/command/rtt
> > github.com/hashicorp/consul/command/snapshot
> > github.com/hashicorp/consul/command/snapshot/inspect
> > github.com/hashicorp/consul/command/snapshot/restore
> > github.com/hashicorp/consul/command/snapshot/save
> > github.com/hashicorp/consul/command/validate
> > github.com/hashicorp/consul/command/version
> > github.com/hashicorp/consul/command/watch
> > github.com/hashicorp/consul/ipaddr github.com/hashicorp/consul/lib
> > github.com/hashicorp/consul/lib/freeport github.com/hashicorp/consul/logger
> > github.com/hashicorp/consul/sentinel github.com/hashicorp/consul/snapshot
> > github.com/hashicorp/consul/testrpc github.com/hashicorp/consul/testutil
> > github.com/hashicorp/consul/testutil/retry
> > github.com/hashicorp/consul/tlsutil github.com/hashicorp/consul/types
> > github.com/hashicorp/consul/version github.com/hashicorp/consul/watch
> > src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider/aws/aws_discover.go:9:2:
> > cannot find package "github.com/aws/aws-sdk-go/aws" in any of:
> >
> > /<<PKGBUILDDIR>>/_build/src/github.com/hashicorp/consul/vendor/github.com/aws/aws-sdk-go/aws
> > (vendor tree)
> > /usr/lib/go-1.10/src/github.com/aws/aws-sdk-go/aws (from $GOROOT)
> > /<<PKGBUILDDIR>>/_build/src/github.com/aws/aws-sdk-go/aws (from
> > $GOPATH)
> > src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider
> >
> > (https://launchpad.net/ubuntu/+source/consul/1.0.7~dfsg1-5)
> >
> > There are a number of other missing packages after this first one.
> >
> > Since these go packages are used by the consul source, it is per se correct
> > for consul to declare build dependencies on them, even if the package has
> > successfully built in Debian without the declaration.
> >
> > Please consider the attached patch, which I have uploaded to Ubuntu to fix
> > the build failure there.
> >
> > --
> > Steve Langasek Give me a lever long enough and a Free OS
> > Debian Developer to set it on, and I can move the world.
> > Ubuntu Developer https://www.debian.org/
> > slanga...@ubuntu.com vor...@debian.org
>
> > diff -Nru consul-1.0.7~dfsg1/debian/control
> > consul-1.0.7~dfsg1/debian/control
> > --- consul-1.0.7~dfsg1/debian/control 2018-08-17 01:48:44.000000000
> > -0700
> > +++ consul-1.0.7~dfsg1/debian/control 2018-10-09 22:38:08.000000000
> > -0700
> > @@ -11,6 +11,7 @@
> > ,golang-github-armon-circbuf-dev
> > ,golang-github-armon-go-metrics-dev (>= 0.0~git20171117~)
> > ,golang-github-armon-go-radix-dev
> > + ,golang-github-aws-aws-sdk-go-dev
> > # ,golang-github-beorn7-perks-dev
> > ,golang-github-bgentry-speakeasy-dev
> > ,golang-github-circonus-labs-circonus-gometrics-dev (>= 1.2.0~)
> > @@ -18,6 +19,7 @@
> > ,golang-github-datadog-datadog-go-dev
> > ,golang-github-davecgh-go-spew-dev
> > ,golang-github-denverdino-aliyungo-dev
> > + ,golang-github-docker-go-connections-dev
> > ,golang-github-elazarl-go-bindata-assetfs-dev (>= 0.0~git20151224~)
> > ,golang-github-fsouza-go-dockerclient-dev
> > ,golang-github-google-gofuzz-dev
> > @@ -47,6 +49,7 @@
> > ,golang-github-hashicorp-serf-dev (>= 0.8.1+git20180508~)
> > ,golang-github-hashicorp-yamux-dev (>= 0.0~git20151129~)
> > ,golang-github-inconshreveable-muxado-dev
> > + ,golang-github-kr-text-dev
> > ,golang-github-mattn-go-isatty-dev
> > ,golang-github-miekg-dns-dev
> > ,golang-github-mitchellh-cli-dev (>= 0.0~git20171129~)
> > @@ -62,6 +65,7 @@
> > ,golang-github-sergi-go-diff-dev
> > ,golang-github-shirou-gopsutil-dev
> > ,golang-golang-x-sys-dev (>= 0.0~git20161012~)
> > + ,golang-google-api-dev
> > Homepage: https://github.com/hashicorp/consul
> > Vcs-Browser: https://salsa.debian.org/go-team/packages/consul
> > Vcs-Git: https://salsa.debian.org/go-team/packages/consul.git
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature
