Package: duplicity
Version: 0.8.05-1
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu focal ubuntu-patch

Hi Alexander,

The duplicity source package includes code in debian/rules to specifically
iterate over all currently-supported versions of python3 in the archive
(py3versions -rv) in order to build its extension for them.  However, it
only build-depends on python3-dev, not on python3-all-dev, which is required
in order to ensure all of these versions of python are available at build
time.

The attached patch fixes the source to build-depend on python3-all-dev, and
also to ensure that the correct version of python is used when invoking
../bin/duplicity at each iteration through the test suite.

Note, however, that even with this patch, duplicity still fails to build
from source in Ubuntu right now where python3.8 has been added as a
supported version of python, due to python3.8-specific test failures:
https://launchpad.net/ubuntu/+source/duplicity/0.8.05-1ubuntu2

Since python3.8 will become the default python in Ubuntu 20.04 (and
presumably also in Debian soon, although I haven't yet seen a timeline
communicated yet on that transition), you may want to care about these
failures as well.  The python3-defaults which adds python3.8 as supported is
currently in Debian experimental.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slanga...@ubuntu.com                                     vor...@debian.org
diff -Nru duplicity-0.8.05/debian/control duplicity-0.8.05/debian/control
--- duplicity-0.8.05/debian/control     2019-10-22 08:42:17.000000000 -0700
+++ duplicity-0.8.05/debian/control     2019-10-25 22:34:10.000000000 -0700
@@ -2,7 +2,7 @@
 Section: utils
 Priority: optional
 Maintainer: Alexander Zangerl <a...@debian.org>
-Build-Depends: debhelper (>= 10.0.0), librsync-dev (>=0.9.6), python3-dev, 
dh-python, python3-setuptools, rdiff, gnupg | gnupg1, par2, python3-lockfile, 
python3-mock, python3-pexpect, python3-fasteners, python3-requests, 
python3-urllib3, python3-coverage, python3-pycodestyle, pylint, python3-pytest, 
python3-pytest-runner, python3-pytest-cov, tox, python3-future, rename, rsync
+Build-Depends: debhelper (>= 10.0.0), librsync-dev (>=0.9.6), python3-all-dev, 
dh-python, python3-setuptools, rdiff, gnupg | gnupg1, par2, python3-lockfile, 
python3-mock, python3-pexpect, python3-fasteners, python3-requests, 
python3-urllib3, python3-coverage, python3-pycodestyle, pylint, python3-pytest, 
python3-pytest-runner, python3-pytest-cov, tox, python3-future, rename, rsync
 Standards-Version: 4.1.3.0
 Homepage: http://duplicity.nongnu.org/
 X-Python3-Version: >= 3.7
diff -Nru duplicity-0.8.05/debian/rules duplicity-0.8.05/debian/rules
--- duplicity-0.8.05/debian/rules       2019-10-22 08:42:17.000000000 -0700
+++ duplicity-0.8.05/debian/rules       2019-10-25 22:34:10.000000000 -0700
@@ -8,6 +8,7 @@
 ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
        set -e -x;\
        for py in $(PYVERS); do \
+  TOXPYTHON=python$$py \
   PYTHONPATH=$(CURDIR)/build/lib.*-$$py  python$$py ./setup.py test ;\
   done
 endif

Reply via email to