On Wed, Oct 16, 2019 at 07:52:00PM +0000, Niels Thykier wrote: > Hi Nicolas, > > I am sorry to hear that our auto-detection broke for haveged.
Hi Niels! Don't be sorry, the provided message and manpages were enough to help me figure it out :) Rather, thanks for working on debhelper in the first place. <3 > > The suggested fix -- calling `dh_makeshlibs --add-udeb=haveged-udeb` -- does > > not work, and I was forced to override to `dh_makeshlibs --no-add-udeb` > > instead. > > Ok, I have added the following warning/hints to that case > > > warning("Hint: Alternatively, if you have merged the > > shared lib package into $udeb_name and it has no"); > > warning("Hint: other packages need to know of this > > library, then use \"--no-add-udeb\""); > > And added the following note to the man page: > [...] Thanks for extending the message & documentation, and even more importantly, thanks for confirming this was the correct thing to do. > Let me know if you have any suggestions for improvements to these texts. :) This seems fine as-is: it clarifies that this is correct to do iff there is nothing that depends on the udeb, and it's discoverable straight from the build log. > > Since it seems reasonable for a udeb to ship the necessary libraries > > directly, > > rather than splitting them to a separate udeb, I would suggest the > > following: > > make `dh_makeshlibs` check not only whether FOO contains the same libraries > > as > > FOO-udeb, but also consider FOO's dependencies from the same source package. > > While an interesting suggestion, I think this is beyond what I am > willing to invest in dh_makeshlibs auto-detection feature at the moment. That's entirely fair. :) Feel free to WONTFIX the bug, or to keep it around if you want to eventually address this. Thanks, nicoo
signature.asc
Description: PGP signature