Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian....@packages.debian.org
Usertags: pu
Hi,
The default behavior of perl Storable::dclone function changed
in buster, setting a default maximum recursion in the structures
[1], [2].
This change has not been spotted before the release, but now
that buster is released and that big clusters are switching to
buster, this bug has been found (before the release, oar was
tested only on smaller cluster).
So, we sould like to revert to the old behavior of Storable::dclone
in the oar package (it is just two variables to set), so that
oar in buster still works on big cluster (> 1000 cores).
You can find in attachment the debdiff of our proposal.
This would close #942467
Regards,
Vincent
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?archive=no&bug=912695
[2] https://rt.perl.org/Public/Bug/Display.html?id=133326
-- System Information:
Debian Release: bullseye/sid
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'oldstable-updates'), (500,
'unstable'), (500, 'testing'), (500, 'stable'), (500, 'oldstable'), (1,
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armel, mipsel
Kernel: Linux 5.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8),
LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru oar-2.5.8/debian/changelog oar-2.5.8/debian/changelog
--- oar-2.5.8/debian/changelog 2019-01-04 21:06:58.000000000 +0100
+++ oar-2.5.8/debian/changelog 2019-10-17 15:31:19.000000000 +0200
@@ -1,3 +1,10 @@
+oar (2.5.8-1+deb10u1) buster; urgency=medium
+
+ * Revert to stretch behavior for Storable::dclone perl function (Closes:
+ #942467)
+
+ -- Vincent Danjean <vdanj...@debian.org> Thu, 17 Oct 2019 15:31:19 +0200
+
oar (2.5.8-1) unstable; urgency=medium
[ Pierre Neyron ]
diff -Nru
oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch
oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch
--- oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch
1970-01-01 01:00:00.000000000 +0100
+++ oar-2.5.8/debian/patches/00-fix-max-recursion-depth-in-perl-storable.patch
2019-10-17 15:31:19.000000000 +0200
@@ -0,0 +1,18 @@
+Fix Max. recursion depth with nested structures
+
+Due to a restriction implemented in Perl's Storable module
+distributed in Buster, Storable::dclone prevent recursions that
+were used before by oar.
+Removing here this limitation, going back to the previous behavior.
+--- a/sources/core/common-libs/lib/OAR/Schedulers/ResourceTree.pm
++++ b/sources/core/common-libs/lib/OAR/Schedulers/ResourceTree.pm
+@@ -7,6 +7,9 @@
+ use Storable qw(dclone);
+ #use Time::HiRes qw(gettimeofday);
+
++$Storable::recursion_limit=-1;
++$Storable::recursion_limit_hash=-1;
++
+
###############################################################################
+ # RESOURCE TREE MANAGEMENT
#
+
###############################################################################
diff -Nru oar-2.5.8/debian/patches/series oar-2.5.8/debian/patches/series
--- oar-2.5.8/debian/patches/series 2019-01-04 21:06:58.000000000 +0100
+++ oar-2.5.8/debian/patches/series 2019-10-17 15:31:19.000000000 +0200
@@ -0,0 +1 @@
+00-fix-max-recursion-depth-in-perl-storable.patch
