Control: tags -1 patch

On 2019-03-13 23:00 +0300, Fedor Khodkov wrote:

> Package: elpa-with-editor
> Version: 2.8.1-1
> Severity: normal
>
> Hello,
>
> Debian package claims elpa-with-editor has version 2.8.1, but inside
> emacs it's seen as 2.6.0.

This causes "git-commit" (shipped in elpa-git-commit) to be listed as
incompatible in Emacs' package manager, as it requires with-editor
>= 2.8.0.

> I suppose version information is generated
> inside debian/rules file, where in line 2 it's still says VERSION=2.6.0

This VERSION should be obtained from the Debian changelog and not be
hardcoded.  Attached is a patch that does the trick using dpkg's
pkg-info.mk Makefile snippets.

Cheers,
       Sven

From 326cb477bd07538615f41b327e98f493337a4a1e Mon Sep 17 00:00:00 2001
From: Sven Joachim <svenj...@gmx.de>
Date: Wed, 16 Oct 2019 10:55:58 +0200
Subject: [PATCH 1/1] d/rules: Compute VERSION from d/changelog

Rather than hardcoding it, which means it gets outdated quickly.
Closes: #924512
---
 debian/rules | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 0bb4fe0..80eb9b2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,5 +1,7 @@
 #!/usr/bin/make -f
-VERSION=2.6.0
+
+include /usr/share/dpkg/pkg-info.mk
+VERSION=$(DEB_VERSION_UPSTREAM)

 CP    ?= install -p -m 644
 MKDIR ?= install -p -m 755 -d
--
2.23.0

Reply via email to