Package: greenbone-security-assistant Version: 7.0.3+dfsg.1-1 Severity: normal
Dear Maintainer, although probably nobody is still using the init scripts ... The gsa daemon gets a few parameters via the DAEMONOPTS shell variable which is built after sourcing the default file /etc/default/greenbone-security-assistant. Now it's not obvious whether a user should be allowed to add extra parameters - in my opinion yes, mostly to override the --timeout setting. But if yes, the default file was the right place for this. However, the statements from line 24 on: | [ "$GSA_ADDRESS" ] && DAEMONOPTS="--listen=$GSA_ADDRESS" | [ "$GSA_PORT" ] && DAEMONOPTS="$DAEMONOPTS --port=$GSA_PORT" | ... makes this a wobbly game: If GSA_ADDRESS is set in the default file, any DAEMONOPTS setting from that place will be discarded. If not, it's taken into account. The same happens in openvas-manager, depending on the value of DATABASE_FILE, whie openvas-scanner explicitely clears DAEMONOPTS. For clarity, please implement a unified behaviour. Regards, Christoph
signature.asc
Description: PGP signature