Package: runit Version: 2.1.2-33rescan1 Followup-For: Bug #935958 > * please make scripts return != 0 in case of failure. `./fetch foo' > exiting with 0 is very confusing.
I have updated the code[1], all script now return nonzero in case of failure. Also there is some improvement on the hackit script. > May I suggest using git? `debcheckout`, if maintainer uses Salsa, or > `gbp import-dsc apt:foo` otherwise. Extra points for making Salsa merge > request in addition to BTS bug. Thanks for the suggestion, I will add this in version 0.3, WIP code will be in [2]. Also I will focus on improving the converter. > * you seem to invent yet-another templating engine with those #dep1# > tokens. I suggest you to re-use something already established, like > mustache or jinja2. bin:ionit may be interested. Didn't know about mustache, jinja2 and ionit. It's a lot of new things to learn, and I don't have the time now, maybe in the future.. > But before patch can be submitted to maintainer, automatic testing is > must. I suggest salsa.debian.org/kaction/daemons. Is there any instruction on how to use it? >> Do I need to 'set -e' in run script, or it's inherited from invoke-run? > No, it is not. Do you think invoke-run should? Mmm, I don't have an strong opinion on that, I think it's fine as it is now. > * please do not print "Starting $NAME". It goes to log, quite > pointless and may confuse scripts/tools that want to analyze log. I know it goes to log, that was exactly my idea but i didn't thought about scripts that want to analyze logs. Runit is absolutely mute and in some case it's hard for me to understand what is wrong with a service. For example, if in the log there is no `Starting NAME` message i know something is wrong with the run file; if i see a stream of `starting NAME Stopping NAME` i know there is some permanent failure condition. I'm not sure I will be able to help in solving bug that users will send about runit services without those markers. Maybe I can change the message into something less confusing like `runsv: starting NAME` and `runsv: NAME stopped` ? > PS. You know that I already got runscript into src:tor and src:acpid? yes I've noticed that :) I've send a couple of patches too and have few others ready (but those need the fix for #934173). Maybe you can help with Anacron? It's QA maintained. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934231 [1] https://salsa.debian.org/Lorenzo.ru.g-guest/runit-tools/tree/nopackage [2] https://salsa.debian.org/Lorenzo.ru.g-guest/runit-tools/tree/next-0.3 Thanks, Lorenzo
