Package: python3-notebook Version: 5.7.8-1 Severity: normal Tags: patch Dear Maintainer,
I tried hitting "new -> terminal" from the notebook file browser. A gray screen with no terminal appeared. I hacked a fix in for me, but my knowledge of javascript is limited and I think term.js isn't designed to work with requirejs modules, so this fix ends up cluttering the global javascript namespace. (And I have no idea how to rebuild the minified .js so I switched terminal.html to use the unminified source.) Also trying to load components/xterm.js-css/index.css was 404ing so I removed it. Diane -- System Information: Debian Release: bullseye/sid APT prefers testing-debug APT policy: (500, 'testing-debug'), (500, 'oldstable-debug'), (500, 'testing'), (500, 'stable'), (110, 'unstable'), (100, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.2.0-2-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_WARN Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages python3-notebook depends on: ii fonts-font-awesome 5.0.10+really4.7.0~dfsg-1 ii libjs-backbone 1.3.3~dfsg-5 ii libjs-bootstrap 3.4.1+dfsg-1 ii libjs-bootstrap-tour 0.12.0+dfsg-2 ii libjs-codemirror 5.43.0-1 ii libjs-es6-promise 4.2.8-5 ii libjs-jed 1.1.1-1 ii libjs-jquery 3.3.1~dfsg-3 ii libjs-jquery-typeahead 2.10.6+dfsg1-1 ii libjs-jquery-ui 1.12.1+dfsg-5 ii libjs-marked 0.5.1+dfsg-1 ii libjs-mathjax 2.7.4+dfsg-1 ii libjs-moment 2.24.0+ds-1 ii libjs-requirejs 2.3.6-1 ii libjs-requirejs-text 2.0.12-1 ii libjs-term.js 0.0.7-1 ii libjs-text-encoding 0.7.0-1 ii libjs-underscore 1.9.1~dfsg-1 ii python3 3.7.3-1 ii python3-ipykernel 4.9.0-1 ii python3-ipython-genutils 0.2.0-1 ii python3-jinja2 2.10.1-1 ii python3-jupyter-client 5.2.3-1 ii python3-jupyter-core 4.5.0-2 ii python3-nbconvert 5.4-2 ii python3-nbformat 4.4.0-1 ii python3-prometheus-client 0.6.0-1 ii python3-send2trash 1.5.0-1 ii python3-terminado 0.8.2-2 ii python3-tornado 5.1.1-4 ii python3-traitlets 4.3.2-1 ii python3-zmq 17.1.2-3 Versions of packages python3-notebook recommends: pn python3-ipywidgets <none> Versions of packages python3-notebook suggests: ii python-notebook-doc 5.7.8-1 -- no debconf information
--- notebook/static/terminal/js/terminado.js 2019-08-28 11:34:32.605416308 -0700
+++ /usr/lib/python3/dist-packages/notebook/static/terminal/js/terminado.js 2019-08-28 10:46:44.570493664 -0700
@@ -1,5 +1,6 @@
-define ([], function(Terminal) {
+define(function(require, exports, module) {
"use strict";
function make_terminal(element, ws_url) {
+ require('/static/components/term.js/term.js');
var ws = new WebSocket(ws_url);
var term = new Terminal({cols: 80, rows: 24});
--- notebook/templates/terminal.html 2019-08-28 09:45:57.028871925 -0700
+++ /usr/lib/python3/dist-packages/notebook/templates/terminal.html 2019-08-28 11:07:22.413702027 -0700
@@ -16,5 +16,4 @@
{{super()}}
<link rel="stylesheet" href="{{ static_url("terminal/css/override.css") }}" type="text/css" />
-<link rel="stylesheet" href="{{static_url("components/xterm.js-css/index.css") }}" type="text/css" />
{% endblock %}
@@ -33,4 +32,4 @@
{{super()}}
-<script src="{{ static_url("terminal/js/main.min.js") }}" type="text/javascript" charset="utf-8"></script>
+<script src="{{ static_url("terminal/js/main.js") }}" type="text/javascript" charset="utf-8"></script>
{% endblock %}
signature.asc
Description: This is a digitally signed message part
