On 19/08/13 11:06, Jérôme Lebleu wrote: > Hi Lisandro, > > Thanks a lot for your review and all your advice! It gives me more > motivation to follow through this package.
Great! I've looked into the changes and really liked what I saw :-) > On Sat, 3 Aug 2019 23:27:28 -0300 Lisandro Damián Nicanor Pérez Meyer > <perezme...@gmail.com> wrote: > > = debian/changelog > > > > As it's the first upload the only line really needed is: > > > > * Initial release (Closes: #694077) > > It's done. > > > = debian/patches > > > > Why are you disabling patches? The patch description is not clear > > about it. I had to read debian/rules to know why :-) > > > > Try this: > > > > override_dh_auto_test-arch: > > <insert tab> xvfb-run -a -s "-screen 0 1024x768x24 +extension RANDR > > +extension RENDER +extension GLX +extension EGL" \ > > dh_auto_test --max-parallel=1 -- > > QT_PLUGIN_PATH=$(CURDIR)/plugins QML2_IMPORT_PATH=$(CURDIR)/qml > > > > The Qt5 version seems to use QML so the above should work. This comes > > from qt3d's debian/rules. > > > > After that override the -indep target: > > > > override_dh_auto_test-indep: > > > > > > And leave no commands in it. This is because this package does not > > seems to have testes for arch:all binary packages (I might be wrong > > though). > > I have try to understand all of this first, so I went step by step and I > succeed to pass the tests with only: > > override_dh_auto_test-arch: > xvfb-run -a dh_auto_test > > More work was needed, I let you review it at > https://salsa.debian.org/jlebleu-guest/qlcplus/commit/54a466af5361321638350cbf8ee2ba2a2893c30d. Looks good, I'll be compiling it hopeully today. > > = debian/copyright > > > > Massimo Callegari's copyright should go at least up to 2018: > > > > 2012-2018 Massimo Callegari <massimocalleg...@yahoo.it> > > > > You are missing many copyright entries and licenses. Please start with: > > > > grep -iRn copyright * > > > > in the project's root directory. You will find many people nott yest listed. > > Indeed!... I have tried to add all missing entries. > > I also try to fix all other warnings reported by lintian. There are > still some Info however: > > * I: qlcplus: hardening-no-fortify-functions > usr/lib/x86_64-linux-gnu/qt5/plugins/qlcplus/libmidiplugin.so > > I would say that it is a false-positive since it is the only one but > I don't know enough to be sure. What do you think? We can start by leaving it as it is. > * I: qlcplus: desktop-entry-lacks-keywords-entry > usr/share/applications/qlcplus-fixtureeditor.desktop > I: qlcplus: desktop-entry-lacks-keywords-entry > usr/share/applications/qlcplus.desktop > > I will see to purpose a patch upstream first. Great. Also not strictly necessary for a fir upload. > Finally, I have - at least - ask to be the owner of this bug as Wouter > was okay with that. > > > Feel free to ping me for sponsorship!!! > > Thanks for your proposal, I am really interested in! In fact, I first > ask a friend of mine, with whom I try to maintain another package, but > he seems quite busy with many other projects. Moreover, having the > sponsor of someone else can only be enriching. Great!
