Hi Alexander,

Alexander Dahl wrote:
> I suspect the problem being the use of 'fallocate' and 'f2fs'. man
> mkswap(8) states this:
> 
>        Note  that  a swap file must not contain any holes.  Using cp(1)
> to create the file is not
>        acceptable.  Neither is use of fallocate(1) on  file  systems
> that  support  preallocated
>        files, such as XFS or ext4, or on copy-on-write filesystems like
> btrfs.  It is recommended
>        to use dd(1) and /dev/zero in these cases.  Please read notes
> from swapon(8) before adding
>        a swap file to copy-on-write filesystems.

Thanks for these hints!

> Hope that helps to fix the package?!

Well, it helps to decide to drop debian/patches/fallocate.patch.

I though never ran into this myself (and wasn't aware of that comment
in mkswap). I also never came across a Raspbian using F2FS so far
although the idea sounds quite obvious.

Will drop that patch with the next upload to Debian Unstable. That
won't fix it for Debian/Raspbian Buster, though, but I might be able
to get it into a stable update.

It's though interesting to see that this patch was in Debian Stretch
and Raspbian Stretch since January 2017 and the first bug report
showed up in late 2018, i.e. nearly two years and a stable release
later, especially since ext4 is said to be affected. (This is no
accusation but rather an explanation why I so far considered this to
be a rather exotic issue.)

                Regards, Axel
-- 
 ,''`.  |  Axel Beckert <a...@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Reply via email to