Package: fped
Severity: normal

Dear Maintainer,

Having asked on the Pkg-electronics-devel mailing list, I am filing this bug
to summarise the packaging file problems with the fped package. The most
important of these from a Debian infrastructure perspective is the incorrect
Vcs-Git field in the control file which prevents the package tracker from
accessing the packaging files repository:

https://tracker.debian.org/pkg/fped

I have attached a patch that applies to the packaging repository...

https://github.com/xiangfu/deb-pkg/

With some minor adjustments, this patch could probably be applied to other
collections of these files. Other aspects of this patch are described below.

The existing copyright file also needs some work to reflect more recent
packaging practices, and this is addressed by the attached patch. I have also
taken the liberty of incorporating the suggested fix to the following bug:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928321

Finally, a watch file has been added to permit detection of upstream
repository updates, although these are infrequent.

Thanks for packaging fped in Debian and I hope the package can be improved
with the changes supplied.

Regards,

Paul


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Foreign Architectures: mipsel

Kernel: Linux 3.16.0-10-586
Locale: LANG=en_GB.ISO-8859-15, LC_CTYPE=en_GB.ISO-8859-15 
(charmap=ISO-8859-15), LANGUAGE=en_GB.ISO-8859-15 (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages fped depends on:
ii  libatk1.0-0          2.32.0-2
ii  libc6                2.28-10
ii  libcairo2            1.16.0-4
ii  libfontconfig1       2.13.1-2
ii  libfreetype6         2.9.1-4
ii  libgdk-pixbuf2.0-0   2.38.1+dfsg-1
ii  libglib2.0-0         2.58.1-2
ii  libgtk2.0-0          2.24.32-3
ii  libpango-1.0-0       1.42.4-7
ii  libpangocairo-1.0-0  1.42.4-7
ii  libpangoft2-1.0-0    1.42.4-7

fped recommends no packages.

fped suggests no packages.
diff --git a/fped/changelog b/fped/changelog
index b0b6a41..200a36a 100644
--- a/fped/changelog
+++ b/fped/changelog
@@ -1,3 +1,17 @@
+fped (0.1+20170511-1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * New snapshot, taken from commit fa98e58
+
+ -- Paul Boddie <p...@boddie.org.uk>  Sun, 30 Jun 2019 18:46:26 +0200
+
+fped (0.1+201210-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add missing Build-Depends on libfl-dev. (Closes: #846426)
+
+ -- Mattia Rizzolo <mat...@debian.org>  Tue, 04 Apr 2017 18:17:39 +0200
+
 fped (0.1+201210-1) unstable; urgency=low
 
   * New snapshot, taken from commit d59b472
diff --git a/fped/compat b/fped/compat
index 7f8f011..f599e28 100644
--- a/fped/compat
+++ b/fped/compat
@@ -1 +1 @@
-7
+10
diff --git a/fped/control b/fped/control
index 45f0206..1dbd864 100644
--- a/fped/control
+++ b/fped/control
@@ -8,7 +8,7 @@ Build-Depends: debhelper (>=  7.4.10), dpkg-dev (>= 1.16.1~), 
pkg-config,
  libgtk2.0-dev
 Standards-Version: 3.9.4
 Homepage: http://downloads.qi-hardware.com/people/werner/fped/gui.html
-Vcs-Git: git://projects.qi-hardware.com/fped.git
+Vcs-Git: https://github.com/xiangfu/deb-pkg/
 
 Package: fped
 Architecture: any
diff --git a/fped/copyright b/fped/copyright
index 92ad11e..da8c6ff 100644
--- a/fped/copyright
+++ b/fped/copyright
@@ -1,39 +1,36 @@
-This work was packaged for Debian by:
-
-    Xiangfu Liu <xian...@openmobilefree.net> on Mon, 4 Oct 2010 15:14:14 +0800
-
-It was downloaded from:
-
-    http://projects.qi-hardware.com/p/fped/
-
-Upstream Author:
-
-    Werner Almesberger <wer...@almesberger.net>
-
-Copyright:
-
-    Copyright 2009-2011 by Werner Almesberger
-
-License:
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 2 of the License, or
-    (at your option) any later version.
-
-    This package is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-On Debian systems, the complete text of the GNU General
-Public License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
-
-The Debian packaging is:
-
-    Copyright (C) 2010 Xiangfu Liu <xian...@openmobilefree.net> and is licensed
-under the GPL version 2, see above.
-
+Format: http://dep.debian.net/deps/dep5/
+Upstream-Name: fped
+Upstream-Contact: Werner Almesberger <wer...@almesberger.net>
+Source: http://projects.qi-hardware.com/p/fped/
+Comment: This package was updated by Paul Boddie <p...@boddie.org.uk>.
+ It was previously debianized by Xiangfu Liu <xian...@openmobilefree.net>.
+
+Files: *
+Copyright: 2009-2017 Werner Almesberger
+           2017 Erich Heinzle <a1039...@gmail.com>
+License: GPL-2+
+Comment: fped tool and documentation
+
+Files: debian/*
+Copyright: 2010-2012 Xiangfu Liu <xian...@openmobilefree.net>
+           2019 Paul Boddie <p...@boddie.org.uk>
+License: GPL-2+
+Comment: Debian packaging files
+
+License: GPL-2+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 2 of the License, or
+ (at your option) any later version.
+ .
+ This package is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ .
+ On Debian systems, the full text of the GNU General Public
+ License version 2 can be found in the file
+ `/usr/share/common-licenses/GPL-2'.
diff --git a/fped/patches/fix-pkg-config.patch 
b/fped/patches/fix-pkg-config.patch
new file mode 100644
index 0000000..986c16c
--- /dev/null
+++ b/fped/patches/fix-pkg-config.patch
@@ -0,0 +1,17 @@
+Index: fped/Makefile
+===================================================================
+--- fped.orig/Makefile
++++ fped/Makefile
+@@ -34,9 +34,10 @@ PNGS = intro-1.png intro-2.png intro-3.p
+
+ SHELL = /bin/bash
+
++PKG_CONFIG ?= pkg-config
+ CPPFLAGS +=
+-CFLAGS_GTK = `pkg-config --cflags gtk+-2.0`
+-LIBS_GTK = `pkg-config --libs gtk+-2.0`
++CFLAGS_GTK = `$(PKG_CONFIG) --cflags gtk+-2.0`
++LIBS_GTK = `$(PKG_CONFIG) --libs gtk+-2.0`
+
+ CFLAGS_WARN = -Wall -Wshadow -Wmissing-prototypes \
+             -Wmissing-declarations -Wno-format-zero-length
diff --git a/fped/patches/series b/fped/patches/series
new file mode 100644
index 0000000..1d51d55
--- /dev/null
+++ b/fped/patches/series
@@ -0,0 +1 @@
+fix-pkg-config.patch
diff --git a/fped/watch b/fped/watch
new file mode 100644
index 0000000..451d75a
--- /dev/null
+++ b/fped/watch
@@ -0,0 +1,2 @@
+version=4
+opts="mode=git, pretty=0.1+%cd" git://projects.qi-hardware.com/fped.git HEAD

Reply via email to