Package: nodejs
Version: 10.15.2~dfsg-2
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu eoan ubuntu-patch
Dear Maintainer,
Please add the included patch for tests, which comes from upstream. This
fixes tests when building /testing against libuv1 > 1.27, which has been
changed from return EINVAL on an unbound sock, to returning EBADF.
*** /tmp/tmpED3lWj/bug_body
In Ubuntu, the attached patch was applied to achieve the above:
* debian/patches/update_test_libuv1_ebadf.patch: Starting in libuv 1.27.0,
test-dgram-address.js should expect EBADF instead of EINVAL.
Thanks for considering the patch.
-- System Information:
Debian Release: buster/sid
APT prefers eoan
APT policy: (500, 'eoan')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.2.0-8-generic (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru nodejs-10.15.2~dfsg/debian/patches/series
nodejs-10.15.2~dfsg/debian/patches/series
--- nodejs-10.15.2~dfsg/debian/patches/series 2019-01-31 03:52:02.000000000
-0500
+++ nodejs-10.15.2~dfsg/debian/patches/series 2019-08-02 13:02:32.000000000
-0400
@@ -12,3 +12,4 @@
fix_disable_cctest.patch
benchmark_without_alice.patch
temporarily_silence_buffer_deprecations.patch
+update_test_libuv1_ebadf.patch
diff -Nru nodejs-10.15.2~dfsg/debian/patches/update_test_libuv1_ebadf.patch
nodejs-10.15.2~dfsg/debian/patches/update_test_libuv1_ebadf.patch
--- nodejs-10.15.2~dfsg/debian/patches/update_test_libuv1_ebadf.patch
1969-12-31 19:00:00.000000000 -0500
+++ nodejs-10.15.2~dfsg/debian/patches/update_test_libuv1_ebadf.patch
2019-08-02 13:01:32.000000000 -0400
@@ -0,0 +1,30 @@
+From 04f30e1a7a5a2f49b611314578758e2009ec2152 Mon Sep 17 00:00:00 2001
+From: cjihrig <cjih...@gmail.com>
+Date: Sat, 16 Mar 2019 13:45:54 -0400
+Subject: [PATCH] test: update test for libuv update
+
+Starting in libuv 1.27.0, test-dgram-address.js should expect
+EBADF instead of EINVAL.
+
+PR-URL: https://github.com/nodejs/node/pull/26707
+Reviewed-By: Santiago Gimeno <santiago.gim...@gmail.com>
+Reviewed-By: Anna Henningsen <a...@addaleax.net>
+Reviewed-By: Richard Lau <ric...@uk.ibm.com>
+Reviewed-By: Refael Ackermann <ref...@gmail.com>
+Reviewed-By: Ruben Bridgewater <ru...@bridgewater.de>
+Reviewed-By: James M Snell <jasn...@gmail.com>
+---
+ test/parallel/test-dgram-address.js | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/test/parallel/test-dgram-address.js
b/test/parallel/test-dgram-address.js
+index f14b910fc27a..2a41755e1c2e 100644
+--- a/test/parallel/test-dgram-address.js
++++ b/test/parallel/test-dgram-address.js
+@@ -77,5 +77,5 @@ if (common.hasIPv6) {
+
+ assert.throws(() => {
+ socket.address();
+- }, /^Error: getsockname EINVAL$/);
++ }, /^Error: getsockname EBADF$/);
+ }
