Control: tags -1 +pending

On Wed, Jul 24, 2019 at 05:17:28PM +0200, Thorsten Glaser wrote:
> 
> 355 tests succeeded     1 tests failed
> Tests failed: f_pre_1970_date_encoding
> 
> I assume this is because x32 is a 32-bit (ILP32) architecture
> with 64-bit time_t.

Thanks for the bug report.  This will be fixed in the next version of
e2fsprogs.  The root cause was how we mocked setting the system time
into the far future by using the E2FSCK_TIME environment variable
during the f_pre_1970_date_encoding test.

                                                - Ted

commit a368e0cbfb33d3050dcccccf0bf5a5539d3dac39
Author: Theodore Ts'o <ty...@mit.edu>
Date:   Wed Jul 24 22:25:11 2019 -0400

    e2fsck: set E2FSCK_TIME correctly on a 32-bit arch with a 64-bit time_t
    
    Addresses-Debian-Bug: #932906
    
    Signed-off-by: Theodore Ts'o <ty...@mit.edu>

diff --git a/e2fsck/e2fsck.c b/e2fsck/e2fsck.c
index 3770bfcb..929bd78d 100644
--- a/e2fsck/e2fsck.c
+++ b/e2fsck/e2fsck.c
@@ -37,7 +37,7 @@ errcode_t e2fsck_allocate_context(e2fsck_t *ret)
 
        time_env = getenv("E2FSCK_TIME");
        if (time_env)
-               context->now = strtoul(time_env, NULL, 0);
+               context->now = (time_t) strtoull(time_env, NULL, 0);
        else {
                context->now = time(0);
                if (context->now < 1262322000) /* January 1 2010 */

Reply via email to