Sean Whitton writes ("Bug#932476: git-debpush gbp/unapplied upstream tree
check"):
> New patch attached addressing all of this -- thanks for the review!
Great, thanks.
Acked-by: Ian Jackson <ijack...@chiark.greenend.org.uk>
And in my master. (IDK if you noticed that the previous version broke
the tagupl-gbp testt; I happened to because I accidentally ran the
test suite on that previous version. This one is better.)
I have tiny style comments:
> + set +e
> + git diff --exit-code "$first".."$second" -- . "$@"
> + git_diff_rc=$?
I would probably have called this variable `rc' and made it local.
> + check_treesame "$upstream_tag" "$branch" ':!debian' ':!**.gitignore'
> \
> + || fail_check_upstream_nonidentical
I would probably have merged some of this a bit more somehow. Maybe
with a check_unapplied shell function.
These are matters of taste.
BTW I appreciate the provision of the new t-expect-fail test subcase.
Ian.
--
Ian Jackson <ijack...@chiark.greenend.org.uk> These opinions are my own.
If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.
