Bug#885893: shairport-sync update hangs during service restart

[Chris Boot]

On 31/12/2017 01:16, Thomas wrote:
> I did an update of my Debian/testing machine which still runs with
> _sysvinit_. During this the shairport-sync package was updated to
> 3.1.4-1.
> 
> During configuration the daemon had to be restarted which hang
> the update process infinite.
> 
> If I killed the shairport-sync process the update process continued but
> left a broken package.
> 
> I think the problem is the following:
[snip]

Hi Thomas,

Thanks for your detailed bug report, and sorry that I have not been able
to give it any attention until now. I have prepared a patch which I
think would resolve this issue, but I don't have any Debian systems that
don't use systemd to test with at the moment. Would you mind testing the
following patch for me, please?

diff --git a/debian/shairport-sync.init b/debian/shairport-sync.init
index 17d9be501dbd..1b7aee7fe1a6 100755
--- a/debian/shairport-sync.init
+++ b/debian/shairport-sync.init
@@ -29,7 +29,12 @@ do_start_prepare() {
                mkdir $piddir
                chown ${USER}: $piddir
        fi
+}

+do_start_cmd_override() {
        # Add --daemon to the command-line arguments
        DAEMON_ARGS="--daemon ${DAEMON_ARGS}"
+
+       # Continue with the standard do_start_cmd() implementation
+       do_start_cmd
 }

Thanks,
Chris

-- 
Chris Boot
bo...@debian.org

signature.asc
Description: OpenPGP digital signature