Package: dgit-infrastructure
Version: 9.2

git-debpush 
  - sends upstream commitish and tag info 
    whenever processing a non-native package.

The tag2upload bot
  - runs git-deborig iff upstream info was provided;
    this should cause a .orig to exist
  - passes --upstream... to dgit iff --quilt=baredebian (only)
    (subject to the bug I have just filed)
dgit
  - always checks that the orig (if there is one) is treesame enough
  - uses upstream git history iff --quilt=baredebian

So this means that in the non-baredebian non-native case, nothing
checks that the supplied git tag is an ancestor of the maintainer
history.

I think the supplied git tag should be an ancestor of the maintainer
history except with --quilt=baredebian.  Is this a thing that should
be checked ?

If so, I propose the following changes:

dgit --upstream-commitish should be tolerated in all non-native
packages and should check that the specified commitish is an ancestor
of the maintainer view.

tag2upload should pass --upstream-commitish whenever upstream info
appeared in the tag.

Ian.

-- 
Ian Jackson <ijack...@chiark.greenend.org.uk>   These opinions are my own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.

Reply via email to