Control: tags -1 - moreinfo Hello Paul,
Control: tags -1 moreinfo > I removed the moreinfo tag as I assume now you will have enough information to make a judgement call on this one, feel free to tell me if I should not have done so. > > I'm asking for the unblock of ruby-airbrussh > > because a critical bug was solved in the last upload. > > > > The bug is related to the package throwing an exception when dealing > > with non UTF-8 characters coming from SSH. > > Can you elaborate a bit why the severity? (Would have been nice to have > that description in the bug you didn't file). Looking at the upstream > bug, it may just be confusing to the user and ugly of course as rsync > was said to keep on running. Is rsync in Debian broken in the same way? > So, the main problem here is that when using capistrano (a deployment tool), the user will think that the deployment failed because ruby-airbrussh will have problems with non UTF-8 characters coming from SSH`ed rsync. I do not have reasons to think that rsync is broken in the same way, as the main problem here is misguiding the user into thinking that there is something wrong with the deployment. Capistrano is used for production critical pipelines at some companies. In summary, the deployment will probably occur normally, but the only guarantee of that would be the user having to manually debug the error and checking whether it succeeded or not under the hood. > > I decided to upload the latest release instead of patching the previous > > release > > Which still means review work by us. We do have quite some unblocks > coming in this last freeze moment. > I can see you have lots of work to do, so if you feel like this should not be fixed for the first Buster release, I will try to address this with stable-updates, if you think that's acceptable. With my maintainer's hat on I say that it's important to fix this before releasing Buster, and the changes are very trivial, but I do acknowledge that the best person to make the call here is someone from the release team, so whatever you say I'm fine with it. -- Samuel Henrique <samueloph>
