Control: tag -1 + moreinfo

On Thu, Mar 28, 2019 at 01:14:13PM +0300, Yuriy M. Kaminskiy wrote:
> When cross-building sqlite3, it fails to detect readline: while
> actual code wants only <readline/readline.h> (see src/shell.c.in),
> but configure.ac checks for <readline.h>;

I am unable to reproduce this issue. The public autobuilder cannot
reproduce it either: http://crossqa.debian.net/src/sqlite3 This is using
sbuild for performing the build. How does your build environment differ
to make sqlite3 fail? Please remove the moreinfo tag when providing an
answer.

> @@ -548,12 +548,12 @@ if test x"$with_readline" != xno; then
>               [with_readline_inc=$withval],
>               [with_readline_inc="auto"])
>       if test "x$with_readline_inc" = xauto; then
> -             AC_CHECK_HEADER(readline.h, [found="yes"], [
> +             AC_CHECK_HEADER(readline/readline.h, [found="yes"], [
>                       found="no"
>                       if test "$cross_compiling" != yes; then

>From here it becomes irrelevant to cross building. The changed lines
are not executed during a cross build.

>                               for dir in /usr /usr/local /usr/local/readline 
> /usr/contrib /mingw; do
> -                                     for subdir in include include/readline; 
> do
> -                                             
> AC_CHECK_FILE($dir/$subdir/readline.h, found=yes)
> +                                     for subdir in include; do
> +                                             
> AC_CHECK_FILE($dir/$subdir/readline/readline.h, found=yes)
>                                               if test "$found" = "yes"; then
>                                                       
> TARGET_READLINE_INC="-I$dir/$subdir"
>                                                       break
> 

Helmut

Reply via email to