Hello,

On Sat 22 Jun 2019 at 04:08pm +0100, Sean Whitton wrote:

> The description of --include-dirty says that it tells dgit to "include
> the changes from your working tree".  However, with -wgf, what it
> actually does is include changes to files that have already been
> committed, but not changes in the form of untracked files.
>
> I think that this might be deliberate, in which case dgit(1) should be
> clarified to say that by 'changes' it means only changes to tracked
> files.  Or perhaps this is a bug.

Why I think this is important: if the user passes -wgf on the command
line perhaps it is reasonable that their file gets nuked, since it seems
like they were asking for a clean, even if -wgf is actually the
selection of a clean mode rather than a request for a clean.  But if
they have git-ff configured as their clean mode in ~/.gitconfig, it is
quite bad for `dgit --include-dirty` to delete stuff which might have
required effort to produce!

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to