On 2019-06-19, at 19:39:12 +0200, Andreas Metzler wrote: > On 2019-06-19 Jeremy Sowden <jer...@azazel.net> wrote: > [...] > > Your patch truncates any string value at the first %. I don't think > > that's the right way to go. > [...] > > https://repo.or.cz/wmaker-crm.git/commit/e037ae3684928a2fbf4a3994562a322f5d3b0c71 > > is supposed to fix this.
That patch seems to be intended to stop parsing after the first section of a desktop file like this: [Desktop Entry] Name=Rxvt Color Unicode Terminal Comment=Use the command line TryExec=urxvt Exec=urxvt Icon=urxvt_48x48.xpm Type=Application Categories=Utility;TerminalEmulator; StartupNotify=true Keywords=Run; Actions=New StartupWMClass=URxvt [Desktop Action New] Name=New Rxvt Color Unicode Terminal Exec=urxvt OnlyShowIn=Unity This bug is about what to do with an Exec like this: Exec=/usr/bin/chromium %U The comments in the source file suggest trying TryExec in preference to Exec and discarding the arguments from the latter if used. However, in fact, if Exec is used, it is used as-is. For %U and %F, I think we can replace them with an empty list, i.e., "". For %u and %f, I think we can _probably_ do likewise. J.
signature.asc
Description: PGP signature
