On Thu, May 09, 2019 at 09:32:32AM +0200, Paul Gevers wrote:
> Hi Daniel,
> 
> On 08-05-2019 23:01, Daniel Kahn Gillmor wrote:
> > Thanks for the pointer to this documentation!  I still have no idea how
> > to apply this for a go package like slt (where i encountered this).  Do
> > i use "Testsuite: autopkgtest-pkg-go" or "Testsuite:
> > autopkgtest-pkg-golang" or something else?  Where would i learn what the
> > appropriate mapping is?
> 
> Actually, I don't know where this mapping is documented, except for in
> the code.

the mapping comes from the name that was chosen by whoever implement the
corresponding support in autodep8. In this case "go" was chosen:

https://salsa.debian.org/ci-team/autodep8/commit/c4e122a5b4e03f353d5026438ef88691e214ad53

> It would be good to document it indeed.

I totally agree that the documentation needs improvement, in both
autodep8 itself and autopkgtest. But it also helps if the
language-specific teams documents this on their side (templates for
debian/* etc).

> If I read the code of autopkgtest correctly, as long as your package is
> supported by autodep8, "Testsuite: autopkgtest-pkg-" should be enough,
> anything after the second hyphen is purely for the user. That said,
> autodep8 uses autopkgtest-pkg-go in its tests.
> 
> paul@testavoira ~ $ rgrep -A1 autopkgtest-pkg- /usr/share/autopkgtest/
> /usr/share/autopkgtest/lib/testdesc.py:                    if
> 'autopkgtest-pkg-' in testsuite:
> /usr/share/autopkgtest/lib/testdesc.py-
> try_autodep8 = True
> 
> Paul
> 
> P.s. we may need to improve this logic, I think the Testsuite header
> should explain this better. I.e. it should be something like "Testsuite:
> autopkgtest-autodep8"

do you mean supporting autopkgtest-autodep8-$foo alongside
autopkgtest-pkg-$foo?

Attachment: signature.asc
Description: PGP signature

Reply via email to