Le 08/05/2019 à 11:22, Xavier a écrit : > Le 08/05/2019 à 10:49, Ritesh Raj Sarraf a écrit : >> Package: node-lockfile >> Version: 1.0.4 >> Severity: normal >> >> Hi, >> >> This is mostly about trying to determine the reason for the change. >> I noticed that in patch `remove-touch.patch`, the requirement for `touch` >> module is worked around by the `fs` module. >> >> Is it because by the minor change you were able to avoid an additional >> package dependency? Or is there any other reason, like `touch` being >> buggy/unmaintained ? >> >> I have a build failure with test `staleness-sync-test` in >> tests/basic.js, which I'm encountering only on slow arm32 hardware. >> >> Your change in the above patch looks good enough to me (and my test >> failure is something I think to do with the slowness of the hardware), >> but I still wanted to check if there is any known reason otherwise, for >> you to go this route and deviate from upstream ? >> >> >> Thanks, >> Ritesh > > Hello, > > This patch was added because node-touch isn't packaged. Since touch is > used only for test, I can push a new version with touch embedded.
Pushed to experimental for now
