Hi! Have I sneakily tried to make you maintainer yet? :) one day somebody will fall for it :)
Quick look at the patch looks sane, I’ll do the merge things when home and in front of the laptop with the right github credentials to do so. Sent from my iPhone > On 29 Apr 2019, at 04:25, Alberto Bertogli <albert...@blitiri.com.ar> wrote: > >> On Sun, Apr 28, 2019 at 11:25:22AM +0200, Mattia Rizzolo wrote: >>> On Mon, Jan 28, 2019 at 05:07:34PM +0000, Alberto Bertogli wrote: >>> As far as I can see, this is caused by a bug/race in libeatmydata's >>> initialization, as described before. >>> >>> It is not a problem in libfiu, or its tests. >>> >>> >>> The attached patch for libeatmydata fixes the issue, but it's mostly for >>> illustration since I don't know how the maintainers would prefer to fix >>> this, and I have not tested it thoroughly (for example there's a chance of >>> infinite recursion in some very odd conditions, but it might be better to >>> leave it on purpose to ease debuggability). >> >> I fail to see those, could you maybe expand on where you think there >> could be infinite recursions? > > Looking at this again, and digging around my git repository, I think I wrote > this note based on a previous iteration of the patch. > > I think the patch in your email fixes the problems I was originally worried > about, and can't find any infinite recursion paths right now. > > Sorry for the confusion! > > Thanks! > Alberto >
