On 29/04/2019 06.21, Otto Kekäläinen wrote:
Apparently the comment in your Github PR was wrong then in
https://github.com/MariaDB/mariadb-connector-c/pull/101#issuecomment-466809308
I asked also you where the commit is in the MR at
https://salsa.debian.org/mariadb-team/mariadb-10.3/merge_requests/15
Could you please research and verify here what version the commit is
shipped in? Or maybe research if it broke something and was reverted
before release?
Thanks for your help!
I'm the author of the upstream PR. The situation is a bit confusing;
here are a couple clarifying points:
1. My PR had other commits for general fixup, but this is the one that
really matters:
https://github.com/MariaDB/mariadb-connector-c/pull/101/commits/748422f4941687c4f4a0bb317db7fca03923b01e
2. The upstream maintainer did not actually merge my PR. Instead, he
made similar changes separately. This is the corresponding upstream
change that really matters:
https://github.com/MariaDB/mariadb-connector-c/commit/31ae1278aa4ba2e4832c279d71f3a06ef80ffbea
The C connector is handled as a subproject within the main server repo.
The relevant commit was pulled in as part of this subproject update:
https://github.com/MariaDB/server/commit/5da6944ea3a592efefd1adc33b1280ad1de66688
Note the commit date of 2019-04-04. The most recent 10.3.x release is
10.3.14 from 2019-04-02, two days earlier.
Thus, I expect that the fix will be in upstream 10.3.15, whenever that
is released.
If you want to patch this in Debian meanwhile, I would suggest just
taking the upstream commit:
https://github.com/MariaDB/mariadb-connector-c/commit/31ae1278aa4ba2e4832c279d71f3a06ef80ffbea
I am fairly sure this change will work without any prerequisites, since
that is what I did initially before I tried to make a more comprehensive
fix.
-Corey
