control: tags -1 patch
please tweak cmake file to correctly use $LIBS :)
---
linux-ftpd-ssl-0.17.36+0.3/debian/patches/use-cmake-as-buildsystem-debian-extras.patch
2019-02-24 14:39:30.000000000 +0100
+++
linux-ftpd-ssl-0.17.36+0.3/debian/patches/use-cmake-as-buildsystem-debian-extras.patch
2019-04-17 17:43:55.000000000 +0200
@@ -12,12 +12,13 @@
include_directories(
BEFORE
"../support/"
-@@ -18,6 +20,8 @@
+@@ -18,6 +20,9 @@
in.ftpd
- crypt
+ ${USE_CRYPT}
support
+ ssl
+ crypto
++ ${USE_PAM}
)
install(
TARGETS in.ftpd
@@ -31,7 +32,7 @@
+
+if(USE_PAM)
+ set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DUSE_PAM=1")
-+ set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -lpam")
++ #set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -lpam")
+endif()
+
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -D_FILE_OFFSET_BITS=64")
diff -Nru
linux-ftpd-ssl-0.17.36+0.3/debian/patches/use-cmake-as-buildsystem.patch
linux-ftpd-ssl-0.17.36+0.3/debian/patches/use-cmake-as-buildsystem.patch
--- linux-ftpd-ssl-0.17.36+0.3/debian/patches/use-cmake-as-buildsystem.patch
2019-02-24 14:39:30.000000000 +0100
+++ linux-ftpd-ssl-0.17.36+0.3/debian/patches/use-cmake-as-buildsystem.patch
2019-04-17 17:44:11.000000000 +0200
@@ -37,7 +37,7 @@
+)
+target_link_libraries(
+ in.ftpd
-+ crypt
++ ${USE_CRYPT}
+ support
+)
+install(
On Wed, 27 Mar 2019 19:46:54 +0000 Matthias Klose <d...@debian.org> wrote:
> Package: src:linux-ftpd-ssl
> Version: 0.17.36+0.3-2.1
> Severity: normal
> Tags: sid bullseye
> User: debian-...@lists.debian.org
> Usertags: ftbfs-gcc-9
>
> Please keep this issue open in the bug tracker for the package it
> was filed for. If a fix in another package is required, please
> file a bug for the other package (or clone), and add a block in this
> package. Please keep the issue open until the package can be built in
> a follow-up test rebuild.
>
> The package fails to build in a test rebuild on at least amd64 with
> gcc-9/g++-9, but succeeds to build with gcc-8/g++-8. The
> severity of this report will be raised before the bullseye release,
> so nothing has to be done for the buster release.
>
> The full build log can be found at:
> http://people.debian.org/~doko/logs/gcc9-20190321/linux-ftpd-ssl_0.17.36+0.3-2.1_unstable_gcc9.log
> The last lines of the build log are at the end of this report.
>
> To build with GCC 9, either set CC=gcc-9 CXX=g++-9 explicitly,
> or install the gcc, g++, gfortran, ... packages from experimental.
>
> apt-get -t=experimental install g++
>
> Common build failures are new warnings resulting in build failures with
> -Werror turned on, or new/dropped symbols in Debian symbols files.
> For other C/C++ related build failures see the porting guide at
> http://gcc.gnu.org/gcc-9/porting_to.html
>
> GCC 9 also passes the linker option --as-needed by default; typical
> build issues are passing libraries before object files to the linker,
> or underlinking of convenience libraries built from the same source.
>
> [...]
> 36 | return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 37 | __bos (__s), __fmt, __va_arg_pack ());
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/ftpd.c:3428:27: warning: '%s'
> directive writing up to 4095 bytes into a region of size 1024
> [-Wformat-overflow=]
> 3428 | sprintf(buf, "%s%s\n", nbuf,
> | ^~ ~~~~
> In file included from /usr/include/stdio.h:873,
> from /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/ftpd.c:96:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note:
> '__builtin___sprintf_chk' output between 2 and 4098 bytes into a destination
> of size 1024
> 36 | return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 37 | __bos (__s), __fmt, __va_arg_pack ());
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [ 66%] Building C object ftpd/CMakeFiles/in.ftpd.dir/logutmp.c.o
> cd /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/obj-x86_64-linux-gnu/ftpd &&
> /usr/bin/cc -I/<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd
> -I/<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/../support -g -O2
> -fdebug-prefix-map=/<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
> -D_FORTIFY_SOURCE=2 -DUSE_PAM=1 -D_FILE_OFFSET_BITS=64 -DHASSETPROCTITLE
> -DUSE_SSL -o CMakeFiles/in.ftpd.dir/logutmp.c.o -c
> /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/logutmp.c
> [ 75%] Building C object ftpd/CMakeFiles/in.ftpd.dir/logwtmp.c.o
> cd /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/obj-x86_64-linux-gnu/ftpd &&
> /usr/bin/cc -I/<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd
> -I/<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/../support -g -O2
> -fdebug-prefix-map=/<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3=.
> -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
> -D_FORTIFY_SOURCE=2 -DUSE_PAM=1 -D_FILE_OFFSET_BITS=64 -DHASSETPROCTITLE
> -DUSE_SSL -o CMakeFiles/in.ftpd.dir/logwtmp.c.o -c
> /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/logwtmp.c
> /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/logwtmp.c: In function
> 'ftpdlogwtmp':
> /<<BUILDDIR>>/linux-ftpd-ssl-0.17.36+0.3/ftpd/logwtmp.c:86:14: warning:
> passing argument 1 of 'time' from incompatible pointer type
> [-Wincompatible-pointer-types]
> 86 | (void)time(&ut.ut_time);
> | ^
> | |
